catch silent async failures on exit

Author: cloudhead

lib/vows.js

@@ -33,6 +33,7 @@ vows.__defineGetter__('reporter', function () {
 });
 
 var stylize = require('vows/console').stylize;
+var console = require('vows/console');
 
 vows.inspect = require('vows/console').inspect;
 vows.prepare = require('vows/extras').prepare;
@@ -128,10 +129,24 @@ function addVow(vow) {
 // If not, report an error message.
 //
 process.addListener('exit', function () {
-    if (vows.suites.filter(function (s) {
-        return (s.results.total > 0) && (s.results.time === null)
-    }).length > 0) {
-        vows.reporter.report(['error', { error: "An EventEmitter has failed to fire.", type: 'promise' }]);
+    var results = { honored: 0, broken: 0, errored: 0, pending: 0, total: 0 };
+
+    vows.suites.forEach(function (s) {
+        if ((s.results.total > 0) && (s.results.time === null)) {
+            vows.reporter.report(['error', { error: "Asynchronous Error", suite: s }]);
+            process.exit(1);
+        }
+        s.batches.forEach(function (b) {
+            if (b.status !== 'end') {
+                results.errored ++;
+                results.total ++;
+                vows.reporter.report(['error', { error: "A callback hasn't fired", batch: b, suite: s }]);
+            }
+            Object.keys(results).forEach(function (k) { results[k] += b[k] });
+        });
+    });
+    if (results.total) {
+        sys.puts(console.result(results));
     }
 });
 

lib/vows/console.js

@@ -60,7 +60,7 @@ this.result = function (event) {
         pending: '- ' + $('Pending').bold.cyan
     }[status] + ' » ';
 
-    if ('time' in event) {
+    if (typeof(event.time) === 'number') {
         time = ' (' + event.time.toFixed(3) + 's)';
         time = this.stylize(time, 'grey');
     }

lib/vows/reporters/dot-matrix.js

@@ -59,7 +59,7 @@ this.report = function (data, s) {
             puts(console.result(event).join('\n'));
             break;
         case 'error':
-            puts('\n\n * ' + stylize(event.error, 'red'));
+            sys.puts('\n* ' + stylize(event.error + ' in ', 'red') + event.suite.subject);
             break;
     }
 };