* add more tests

Author: alecsammon

decompression.go

@@ -62,10 +62,6 @@ func decompressTarXz(tarReader func(*xz.Reader) (func() (*tar.Header, error), fu
 			return errorExtractingPostgres(err)
 		}
 
-		if err := os.MkdirAll(filepath.Dir(finalPath), os.ModePerm); err != nil {
-			return errorExtractingPostgres(err)
-		}
-
 		switch header.Typeflag {
 		case tar.TypeReg:
 			outFile, err := os.OpenFile(targetPath, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode))

decompression_test.go

@@ -176,3 +176,11 @@ func Test_decompressTarXz_ErrorWhenArchiveCorrupted(t *testing.T) {
 
 	assert.EqualError(t, err, "unable to extract postgres archive: xz: data is corrupt")
 }
+
+func Test_decompressTarXz_ErrorWithInvalidDestination(t *testing.T) {
+	archive, cleanUp := createTempXzArchive()
+	defer cleanUp()
+
+	err := decompressTarXz(defaultTarReader, archive, string(rune(0)))
+	assert.EqualError(t, err, "unable to extract postgres archive: mkdir \x00: invalid argument")
+}

rename_test.go

@@ -0,0 +1,21 @@
+package embeddedpostgres
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func Test_renameOrIgnore_NoErrorOnEEXIST(t *testing.T) {
+	tmpDir, err := os.MkdirTemp("", "test_dir")
+	require.NoError(t, err)
+
+	tmpFil, err := os.CreateTemp("", "test_file")
+	require.NoError(t, err)
+
+	// os.Rename would return an error here, ensure that the error is handled and returned as nil
+	err = renameOrIgnore(tmpFil.Name(), tmpDir)
+	assert.NoError(t, err)
+}