Skip to content

Saving PHP file crashes language server #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nanaasumadu opened this issue Jun 23, 2017 · 1 comment
Closed

Saving PHP file crashes language server #431

nanaasumadu opened this issue Jun 23, 2017 · 1 comment

Comments

@nanaasumadu
Copy link

nanaasumadu commented Jun 23, 2017

[Error - 8:35:25 AM] Request textDocument/formatting failed.
  Message: Exception: Unable to format file in /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/felixfbecker/language-server/src/Formatter.php:52
Stack trace:
#0 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/felixfbecker/language-server/src/PhpDocument.php(179): LanguageServer\Formatter::format('<?php\n/**\n*\n*/\n...', 'file:///Users/n...')
#1 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/felixfbecker/language-server/src/Server/TextDocument.php(160): LanguageServer\PhpDocument->getFormattedText()
#2 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/sabre/event/lib/Promise.php(242): LanguageServer\Server\TextDocument->LanguageServer\Server\{closure}(Object(LanguageServer\PhpDocument))
#3 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/sabre/event/lib/Loop/Loop.php(261): Sabre\Event\Promise->Sabre\Event\{closure}()
#4 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/sabre/event/lib/Loop/Loop.php(215): Sabre\Event\Loop\Loop->runNextTicks()
#5 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/sabre/event/lib/Loop/Loop.php(194): Sabre\Event\Loop\Loop->tick(true)
#6 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/sabre/event/lib/Loop/functions.php(122): Sabre\Event\Loop\Loop->run()
#7 /Users/nana/.vscode-insiders/extensions/felixfbecker.php-intellisense-1.4.1/vendor/felixfbecker/language-server/bin/php-language-server.php(102): Sabre\Event\Loop\run()
#8 {main}
  Code: -32603 
@felixfbecker felixfbecker added crash and removed crash labels Jun 24, 2017
@felixfbecker
Copy link
Owner

It actually errors while formatting the file - make sure to disable formatOnSave. It's also not crash, just an error. Pretty sure this is tracked already in a different issue and will be solved once we do formatting through the new parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants