Skip to content

documentSymbols: Only report variable declarations, not variable access #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixfbecker opened this issue Sep 9, 2016 · 2 comments
Labels

Comments

@felixfbecker
Copy link
Owner

felixfbecker commented Sep 9, 2016

screenshot 5

$array is only declared once, but appears for every access too. Need to

  • Only use a variable assignment node, and then take the variable from there
  • Only add the variable once per scope
@felixfbecker felixfbecker changed the title documentSymbols: Only report variable declartions, not variable access documentSymbols: Only report variable declarations, not variable access Sep 10, 2016
@felixfbecker felixfbecker reopened this Sep 10, 2016
@felixfbecker
Copy link
Owner Author

The same is true for global symbol search and classes that are imported with use

@felixfbecker
Copy link
Owner Author

Fixed in 6be53ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant