Skip to content

Update workbox-webpack-plugin to strip deprecated core-js@2.6.11 #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahnunchik opened this issue Feb 25, 2020 · 1 comment
Open

Update workbox-webpack-plugin to strip deprecated core-js@2.6.11 #8553

mahnunchik opened this issue Feb 25, 2020 · 1 comment

Comments

@mahnunchik
Copy link

Is your proposal related to a problem?

Update workbox-webpack-plugin to strip deprecated core-js@2.6.11.

Describe the solution you'd like

└─┬ react-scripts@3.4.0
  └─┬ workbox-webpack-plugin@4.3.1
    └─┬ workbox-build@4.3.1
      └─┬ strip-comments@1.0.2
        └─┬ babel-plugin-transform-object-rest-spread@6.26.0
          └─┬ babel-runtime@6.26.0
            └── core-js@2.6.11

https://www.npmjs.com/package/workbox-webpack-plugin

@doc-duncan
Copy link

doc-duncan commented Oct 12, 2020

To avoid this warning I think workbox-webpack-plugin would have to jump all the way to v6x because v5x still depends on a workbox-build v5x which depends on strip-comments@1.0.2 still, as shown here

However, workbox-build v6x depends on strip-comments@2.0.1 which does not have the babel-plugin-transform-object-rest-spread dependency

workbox-build v6x package.json

strip-comments v2x package.json

update

After some further digging I found this issue and pr that was added to v2x of strip-comments but is a simple fix I would think to remediate that dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants