-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Document CSS being removed or force CSS to be effectful #5188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
A downside to forcing CSS to be effectful, is that it wallpapers over mis-configured packages, and means non-CRA tooling (eg Neutrino) will appear to be broken to end users unless we also adopt the workaround. |
I guess let's mention it in migration notes prominently, and direct to webpack/webpack#6571 for discussion. |
On the other hand I don't quite feel comfortable with production breakages because of that. I'd feel safer switching to new webpack behavior after webpack adds a warning or an error for this. |
Do we know of a scenario where importing CSS is not effectful? |
CSS modules isn't. But @sokra said CSS itself is always effectful. |
Right -- he made it sound like we can apply it at the loader level, which means we can apply it to |
Yep. Let's do it for now and we can decide to break in a future major once they have a warning. |
We need to make a decision on #5140.
I'm leaning towards forcing
*.{css,sass,scss}
files to be effectful.The text was updated successfully, but these errors were encountered: