Skip to content

Production app only works when the homepage is left blank #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timurtu opened this issue Jan 3, 2017 · 2 comments
Closed

Production app only works when the homepage is left blank #1342

timurtu opened this issue Jan 3, 2017 · 2 comments

Comments

@timurtu
Copy link

timurtu commented Jan 3, 2017

App with the problem.

Using pushstate-server the browser looks for a non-existent /proverb-generator/static/js/main.916a0ac9.js file when my package.json says

...
"homepage": "http://timurtu.github.io/proverb-generator"
...

It loads when I build leaving the homepage blank

...
"homepage": ""
...

Using https://github.com/timurtu/proverb-generator as the homepage property fails with the same error.

I saw a similar issue where it will only work with http but this error still occurs after removing the s.

@gaearon
Copy link
Contributor

gaearon commented Jan 3, 2017

Probably a duplicate of #1335?

Scratch that.

@gaearon
Copy link
Contributor

gaearon commented Jan 3, 2017

If you build for GH Pages you can’t use pushstate-server locally like this. It will assume files exist at / whereas they exist at /proverb-generator. For now this is working as designed: you can either build for / path (and use pushstate-server) or build for /proverb-generator (and deploy to GH Pages).

I know this is not super convenient and we’ll need to look into it again as part of solving #1094. Please subscribe to that issue if you’re interested.

I’m closing this specific issue since it is not actionable at the moment. This is just how it works right now.

@gaearon gaearon closed this as completed Jan 3, 2017
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants