release: add release script #903

Elbehery · 2025-02-10T23:46:08Z

This PR adds release.sh script to automate the process of releasing bbolt repo.

resolves #896

Below is output of release.sh run

melbeher@melbeher-mac bbolt % ./scripts/release.sh               version_20250212
enter release string according to semantic versioning (e.g. v1.2.3).
v1.4.0-beta.15
fatal: a branch named 'version_20250212' already exists
Updating version from '1.4.0-alpha.0' to '1.4.0-beta.15' in 'version.go'
committing 'version.go'
[version_20250212 234b458] Update version to 1.4.0-beta.15
 1 file changed, 1 insertion(+), 1 deletion(-)
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 12 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 379 bytes | 379.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To github.com:Elbehery/bbolt.git
 + 9ad97a4...234b458 version_20250212 -> version_20250212 (forced update)
branch 'version_20250212' set up to track 'origin/version_20250212'.
'version.go' has been committed to remote repo.
Creating new tag for 'v1.4.0-beta.15'
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
To github.com:Elbehery/bbolt.git
 * [new tag]         v1.4.0-beta.15 -> v1.4.0-beta.15
Tag 'v1.4.0-beta.15' has been created and pushed to remote repo.
SUCCESS

scripts/release.sh

ivanvc · 2025-02-10T23:54:07Z

@Elbehery, we don't have a shellcheck CI check here (yet). Can you run shellcheck on your script? I believe there are a couple of instances where it will give warnings :)

Elbehery · 2025-02-11T00:20:58Z

@Elbehery, we don't have a shellcheck CI check here (yet). Can you run shellcheck on your script? I believe there are a couple of instances where it will give warnings :)

done 👍🏽 .. so it was mainly adding "" around vars 👍🏽

ivanvc

Thanks for the pull request, @Elbehery. I left some comments ✌️

scripts/release.sh

Elbehery · 2025-02-12T21:21:40Z

the last run after updates

melbeher@melbeher-mac bbolt % ./scripts/release.sh               version_20250212
enter release string according to semantic versioning (e.g. v1.2.3).
v1.4.0-beta.15
fatal: a branch named 'version_20250212' already exists
Updating version from '1.4.0-alpha.0' to '1.4.0-beta.15' in 'version.go'
committing 'version.go'
[version_20250212 234b458] Update version to 1.4.0-beta.15
 1 file changed, 1 insertion(+), 1 deletion(-)
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 12 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 379 bytes | 379.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To github.com:Elbehery/bbolt.git
 + 9ad97a4...234b458 version_20250212 -> version_20250212 (forced update)
branch 'version_20250212' set up to track 'origin/version_20250212'.
'version.go' has been committed to remote repo.
Creating new tag for 'v1.4.0-beta.15'
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
To github.com:Elbehery/bbolt.git
 * [new tag]         v1.4.0-beta.15 -> v1.4.0-beta.15
Tag 'v1.4.0-beta.15' has been created and pushed to remote repo.
SUCCESS

ivanvc

Thanks for the changes, @Elbehery. Sorry if there has been a lot of back and forth. I should have tested your script locally (apologies). Thanks again :)

scripts/release.sh

ivanvc

Thanks for the updates, @Elbehery. Please take a look at my comments.

scripts/release.sh

Elbehery · 2025-03-14T00:06:56Z

/retest

Elbehery · 2025-03-17T15:59:37Z

@ivanvc am i missing anything here ?

ivanvc

I tested this in my fork, and it works as expected. It pushes the version update in version/version.go, and creates and pushes a tag.

LGTM. Thanks, @Elbehery.

k8s-ci-robot · 2025-03-17T19:58:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery, ivanvc
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahrtr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

scripts/release.sh

ivanvc

Hi, @Elbehery. Thanks for the changes. Please take a look at my comments.

scripts/release.sh

ahrtr · 2025-05-05T18:26:56Z

Sorry for the late response. @ivanvc is this PR good to go?

Elbehery · 2025-05-05T18:54:00Z

hello

will update tonight, really lost track of it :'(

ivanvc · 2025-05-05T18:54:33Z

Sorry for the late response. @ivanvc is this PR good to go?

No, we're missing changes from the last batch of comments. The script, as it is right now, would fail to execute.

Elbehery · 2025-05-05T18:55:23Z

Sorry for the late response. @ivanvc is this PR good to go?

No, we're missing changes from the last batch of comments. The script, as it is right now, would fail to execute.

I deeply apologize, has lost track of this

will update tonight

Elbehery · 2025-05-07T15:16:48Z

@ivanvc updated 👍🏽 PTAL

Elbehery · 2025-05-18T20:30:51Z

Hello ✋🏽

I have just tested this, find the output below

./scripts/release.sh                                                                     version_20250518
enter release string according to semantic versioning (e.g. v1.2.3).
v1.4.0-beta.15
fatal: a branch named 'version_20250518' already exists
Updating version from '1.4.0-alpha.0' to '1.4.0-beta.15' in 'version.go'
committing 'version.go'
[version_20250518 681aa33] Update version to 1.4.0-beta.15
 1 file changed, 1 insertion(+), 1 deletion(-)
'version.go' has been committed to remote repo.
Creating new tag for 'v1.4.0-beta.15'
gpg: directory '/Users/melbeher/.gnupg' created
gpg: /Users/melbeher/.gnupg/trustdb.gpg: trustdb created
gpg: error reading key: No public key

I just don't have the config correct, but any more changes required here ?

Elbehery · 2025-05-19T21:43:24Z

@ivanvc updated, now everything happens in the release-{MINOR} branch

see below run of current script

./scripts/release.sh   
enter release string according to semantic versioning (e.g. v1.2.3).
v1.4.0-beta.15
Switched to a new branch 'release_1.4'
Updating version from '1.4.0-alpha.0' to '1.4.0-beta.15' in 'version.go'
committing 'version.go'
[release_1.4 6bbe051] Update version to 1.4.0-beta.15
 1 file changed, 1 insertion(+), 1 deletion(-)
'version.go' has been committed to remote repo.
Creating new tag for 'v1.4.0-beta.15'
gpg: error reading key: No public key

scripts/release.sh

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>

Elbehery · 2025-05-20T01:32:28Z

/retest

ivanvc · 2025-05-20T18:40:49Z

Thanks for the changes, @Elbehery. I'll test locally in my fork and then provide a review.

k8s-ci-robot added the size/M label Feb 10, 2025

Elbehery force-pushed the 20250210-add-release-script branch from 0b369bb to 7649a72 Compare February 10, 2025 23:46

Elbehery commented Feb 10, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

Elbehery commented Feb 10, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

Elbehery force-pushed the 20250210-add-release-script branch from 7649a72 to d35e27d Compare February 11, 2025 00:20

Elbehery force-pushed the 20250210-add-release-script branch 2 times, most recently from 50ecec3 to ff51289 Compare February 11, 2025 15:37

Elbehery assigned ahrtr Feb 11, 2025

ivanvc reviewed Feb 12, 2025

View reviewed changes

Elbehery force-pushed the 20250210-add-release-script branch 3 times, most recently from f10036b to 5a05933 Compare February 12, 2025 21:18

Elbehery force-pushed the 20250210-add-release-script branch 3 times, most recently from 9afab2b to fe76a05 Compare February 13, 2025 10:49

ivanvc reviewed Feb 14, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

Elbehery force-pushed the 20250210-add-release-script branch from fe76a05 to 0e085bb Compare March 13, 2025 23:29

ivanvc reviewed Mar 13, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Outdated Show resolved Hide resolved

Elbehery force-pushed the 20250210-add-release-script branch from 0e085bb to f2a654c Compare March 13, 2025 23:47

ivanvc approved these changes Mar 17, 2025

View reviewed changes

ivanvc reviewed Mar 17, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

Elbehery force-pushed the 20250210-add-release-script branch from f2a654c to 2766874 Compare March 17, 2025 21:30

ivanvc reviewed Mar 28, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

scripts/release.sh Show resolved Hide resolved

Elbehery force-pushed the 20250210-add-release-script branch from 2766874 to bb59313 Compare May 7, 2025 15:16

Elbehery force-pushed the 20250210-add-release-script branch from bb59313 to c152051 Compare May 19, 2025 21:36

ivanvc reviewed May 19, 2025

View reviewed changes

scripts/release.sh Outdated Show resolved Hide resolved

release: add release script

3062915

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>

Elbehery force-pushed the 20250210-add-release-script branch from c152051 to 3062915 Compare May 19, 2025 23:03

Elbehery requested review from ahrtr and ivanvc May 20, 2025 04:07

release: add release script #903

Are you sure you want to change the base?

release: add release script #903

Uh oh!

Conversation

Elbehery commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivanvc commented Feb 10, 2025

Uh oh!

Elbehery commented Feb 11, 2025

Uh oh!

ivanvc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Elbehery commented Feb 12, 2025

Uh oh!

ivanvc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivanvc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Elbehery commented Mar 14, 2025

Uh oh!

Elbehery commented Mar 17, 2025

Uh oh!

ivanvc left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 17, 2025

Uh oh!

Uh oh!

ivanvc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ahrtr commented May 5, 2025

Uh oh!

Elbehery commented May 5, 2025

Uh oh!

ivanvc commented May 5, 2025

Uh oh!

Elbehery commented May 5, 2025

Uh oh!

Elbehery commented May 7, 2025

Uh oh!

Elbehery commented May 18, 2025

Uh oh!

Elbehery commented May 19, 2025

Uh oh!

Uh oh!

Elbehery commented May 20, 2025

Uh oh!

ivanvc commented May 20, 2025

Uh oh!

Uh oh!

Elbehery commented Feb 10, 2025 •

edited

Loading