Skip to content

Commit 2aca70b

Browse files
jacojoubertRobbieTheWagner
authored andcommitted
Be more explicit on where label is located (#404)
* Be more explicit on where label is located * Be more explicit about section's label * Use @ instead of this * Add ember-angle-bracket-invocation-polyfill * Move to deps * Add ember-named-arguments-polyfill
1 parent eaa6cbc commit 2aca70b

File tree

4 files changed

+25
-5
lines changed

4 files changed

+25
-5
lines changed

addon/components/docs-viewer/x-nav-item/template.hbs

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
activeClass='docs-text-brand docs-font-medium'
66
data-test-id='nav-item'
77
data-test-label=label}}
8-
{{label}}
8+
{{@label}}
99
{{/link-to}}
1010
{{else}}
1111
{{#link-to route
1212
class='docs-text-grey-darker docs-no-underline hover:docs-underline'
1313
activeClass='docs-text-brand docs-font-medium'
1414
data-test-id='nav-item'
1515
data-test-label=label}}
16-
{{label}}
16+
{{@label}}
1717
{{/link-to}}
1818
{{/if}}
1919
</li>

addon/components/docs-viewer/x-section/template.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
{{#if hasBlock}}
77
{{yield}}
88
{{else}}
9-
{{label}}
9+
{{@label}}
1010
{{/if}}
1111
</li>

package.json

+2
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"broccoli-source": "^1.1.0",
3838
"broccoli-stew": "^2.0.0",
3939
"chalk": "^2.4.2",
40+
"ember-angle-bracket-invocation-polyfill": "^2.0.2",
4041
"ember-assign-polyfill": "^2.6.0",
4142
"ember-auto-import": "^1.5.2",
4243
"ember-cli-autoprefixer": "^0.8.1",
@@ -57,6 +58,7 @@
5758
"ember-href-to": "^1.15.1",
5859
"ember-keyboard": "^4.0.0",
5960
"ember-modal-dialog": "^3.0.0-beta.4",
61+
"ember-named-arguments-polyfill": "^1.0.0",
6062
"ember-responsive": "^3.0.5",
6163
"ember-router-generator": "^2.0.0",
6264
"ember-router-scroll": "^1.2.1",

yarn.lock

+20-2
Original file line numberDiff line numberDiff line change
@@ -4795,6 +4795,16 @@ elliptic@^6.0.0:
47954795
minimalistic-assert "^1.0.0"
47964796
minimalistic-crypto-utils "^1.0.0"
47974797

4798+
ember-angle-bracket-invocation-polyfill@^2.0.2:
4799+
version "2.0.2"
4800+
resolved "https://registry.yarnpkg.com/ember-angle-bracket-invocation-polyfill/-/ember-angle-bracket-invocation-polyfill-2.0.2.tgz#117ab5238305f11046a2eb3a5bc026c98d2cf5c1"
4801+
integrity sha512-HkG0xyTHtAhWVjU0Q5V/i4xe4FRvNIOaiUEgIvN815F3TIUboV/J0xhYgivm0uDZp9lAYUVF+U5PI1sCnlC3Og==
4802+
dependencies:
4803+
ember-cli-babel "^6.17.0"
4804+
ember-cli-version-checker "^2.1.2"
4805+
ember-compatibility-helpers "^1.0.2"
4806+
silent-error "^1.1.1"
4807+
47984808
ember-app-scheduler@^1.0.5:
47994809
version "1.0.8"
48004810
resolved "https://registry.yarnpkg.com/ember-app-scheduler/-/ember-app-scheduler-1.0.8.tgz#37adacce2fa5ab59324e2c0b08f3c4a3568025b4"
@@ -4899,7 +4909,7 @@ ember-cli-babel-plugin-helpers@^1.0.0, ember-cli-babel-plugin-helpers@^1.1.0:
48994909
resolved "https://registry.yarnpkg.com/ember-cli-babel-plugin-helpers/-/ember-cli-babel-plugin-helpers-1.1.0.tgz#de3baedd093163b6c2461f95964888c1676325ac"
49004910
integrity sha512-Zr4my8Xn+CzO0gIuFNXji0eTRml5AxZUTDQz/wsNJ5AJAtyFWCY4QtKdoELNNbiCVGt1lq5yLiwTm4scGKu6xA==
49014911

4902-
ember-cli-babel@^6.0.0-beta.4, ember-cli-babel@^6.0.0-beta.7, ember-cli-babel@^6.10.0, ember-cli-babel@^6.11.0, ember-cli-babel@^6.12.0, ember-cli-babel@^6.16.0, ember-cli-babel@^6.3.0, ember-cli-babel@^6.6.0, ember-cli-babel@^6.8.1, ember-cli-babel@^6.8.2:
4912+
ember-cli-babel@^6.0.0-beta.4, ember-cli-babel@^6.0.0-beta.7, ember-cli-babel@^6.10.0, ember-cli-babel@^6.11.0, ember-cli-babel@^6.12.0, ember-cli-babel@^6.16.0, ember-cli-babel@^6.17.0, ember-cli-babel@^6.3.0, ember-cli-babel@^6.6.0, ember-cli-babel@^6.8.1, ember-cli-babel@^6.8.2:
49034913
version "6.18.0"
49044914
resolved "https://registry.yarnpkg.com/ember-cli-babel/-/ember-cli-babel-6.18.0.tgz#3f6435fd275172edeff2b634ee7b29ce74318957"
49054915
integrity sha512-7ceC8joNYxY2wES16iIBlbPSxwKDBhYwC8drU3ZEvuPDMwVv1KzxCNu1fvxyFEBWhwaRNTUxSCsEVoTd9nosGA==
@@ -5450,7 +5460,7 @@ ember-code-snippet@^2.4.1:
54505460
es6-promise "^1.0.0"
54515461
glob "^7.1.3"
54525462

5453-
ember-compatibility-helpers@^1.1.1, ember-compatibility-helpers@^1.1.2, ember-compatibility-helpers@^1.2.0:
5463+
ember-compatibility-helpers@^1.0.2, ember-compatibility-helpers@^1.1.1, ember-compatibility-helpers@^1.1.2, ember-compatibility-helpers@^1.2.0:
54545464
version "1.2.0"
54555465
resolved "https://registry.yarnpkg.com/ember-compatibility-helpers/-/ember-compatibility-helpers-1.2.0.tgz#feee16c5e9ef1b1f1e53903b241740ad4b01097e"
54565466
integrity sha512-pUW4MzJdcaQtwGsErYmitFRs0rlCYBAnunVzlFFUBr4xhjlCjgHJo0b53gFnhTgenNM3d3/NqLarzRhDTjXRTg==
@@ -5653,6 +5663,14 @@ ember-modal-dialog@^3.0.0-beta.4:
56535663
ember-ignore-children-helper "^1.0.1"
56545664
ember-wormhole "^0.5.5"
56555665

5666+
ember-named-arguments-polyfill@^1.0.0:
5667+
version "1.0.0"
5668+
resolved "https://registry.yarnpkg.com/ember-named-arguments-polyfill/-/ember-named-arguments-polyfill-1.0.0.tgz#0b81fb81a7cef2c89e9e1d0278b579e708bf4ded"
5669+
integrity sha1-C4H7gafO8sienh0CeLV55wi/Te0=
5670+
dependencies:
5671+
ember-cli-babel "^6.6.0"
5672+
ember-cli-version-checker "^2.1.2"
5673+
56565674
ember-native-dom-helpers@^0.5.3:
56575675
version "0.5.10"
56585676
resolved "https://registry.yarnpkg.com/ember-native-dom-helpers/-/ember-native-dom-helpers-0.5.10.tgz#9c7172e4ddfa5dd86830c46a936e2f8eca3e5896"

0 commit comments

Comments
 (0)