Error on multivalue inputs that we do not handle (WebAssembly#5962)

Before in getType() we silently dropped the params of a signature type. Now we verify that
it is none, or we error.

Helps WebAssembly#5950

Author: kripken

src/wasm/wasm-binary.cpp

@@ -2037,7 +2037,11 @@ Type WasmBinaryReader::getType(int initial) {
   // Single value types are negative; signature indices are non-negative
   if (initial >= 0) {
     // TODO: Handle block input types properly.
-    return getSignatureByTypeIndex(initial).results;
+    auto sig = getSignatureByTypeIndex(initial);
+    if (sig.params != Type::none) {
+      throwError("control flow inputs are not supported yet");
+    }
+    return sig.results;
   }
   Type type;
   if (getBasicType(initial, type)) {
@@ -2088,7 +2092,7 @@ HeapType WasmBinaryReader::getIndexedHeapType() {
 Type WasmBinaryReader::getConcreteType() {
   auto type = getType();
   if (!type.isConcrete()) {
-    throw ParseException("non-concrete type when one expected");
+    throwError("non-concrete type when one expected");
   }
   return type;
 }

test/lit/binary/bad-multivalue-block.test

@@ -0,0 +1,16 @@
+;; Test that we error properly on a block with a bad multivalue (inputs).
+
+;; File contents:
+;;
+;; (module
+;;   (func $test
+;;     i32.const 0
+;;     (block (param i32)
+;;       drop
+;;     )
+;;   )
+;; )
+
+;; RUN: not wasm-opt -all %s.wasm 2>&1 | filecheck %s
+
+;; CHECK: control flow inputs are not supported yet

test/lit/binary/bad-multivalue-block.test.wasm

@@ -0,0 +1,22 @@
+;; Test that we error properly on an if with a bad multivalue (inputs).
+
+;; File contents:
+;;
+;; (module
+;;   (func $test
+;;     i32.const 0
+;;     i32.const 1
+;;     (if (param i32)
+;;       (then
+;;         drop
+;;       )
+;;       (else
+;;         drop
+;;       )
+;;     )
+;;   )
+;; )
+
+;; RUN: not wasm-opt -all %s.wasm 2>&1 | filecheck %s
+
+;; CHECK: control flow inputs are not supported yet