Skip to content

Require Authorization on Hubs as a Global Option #5306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikaelm12 opened this issue Jun 13, 2018 · 4 comments
Closed

Require Authorization on Hubs as a Global Option #5306

mikaelm12 opened this issue Jun 13, 2018 · 4 comments
Labels
area-signalr Includes: SignalR clients and servers Needs: Design This issue requires design work before implementating.
Milestone

Comments

@mikaelm12
Copy link
Contributor

I was thinking we could introduce a global hub option for requiring auth on all hubs. There was a way to do this in classic SignalR but for ASP.NET Core SignalR you'd have to add the Authorize tag to each hub.

It could look something like

services.AddSignalR(options => 
{
    options.RequireAuthorization = true
})
@davidfowl
Copy link
Member

Yea that API might be a bit too simplistic. We may want to look at the hub pipeline modules again.

@mikaelm12
Copy link
Contributor Author

Yeah, that's fine. Was throwing something out there to start the conversation. Just wanted us to take a look at the idea.

@mikaelm12 mikaelm12 changed the title Require Authorize on Hubs as a Global Option Require Authorization on Hubs as a Global Option Jun 13, 2018
@aspnet-hello aspnet-hello transferred this issue from aspnet/SignalR Dec 17, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 17, 2018
@aspnet-hello aspnet-hello added area-signalr Includes: SignalR clients and servers cost: M labels Dec 17, 2018
@muratg muratg modified the milestones: 3.0.0, Backlog Jan 30, 2019
@muratg
Copy link
Contributor

muratg commented Jan 30, 2019

Backlogging this.

@analogrelay analogrelay added Needs: Design This issue requires design work before implementating. and removed status: Needs Design labels Mar 21, 2019
@analogrelay
Copy link
Contributor

Rolling in to #5353

@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers Needs: Design This issue requires design work before implementating.
Projects
None yet
Development

No branches or pull requests

5 participants