Skip to content

Hub methods can soft-lock the connection #41997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #44831
rafikiassumani-msft opened this issue Jun 2, 2022 · 3 comments · Fixed by #42796
Open
Tracked by #44831

Hub methods can soft-lock the connection #41997

rafikiassumani-msft opened this issue Jun 2, 2022 · 3 comments · Fixed by #42796
Assignees
Labels
area-signalr Includes: SignalR clients and servers severity-blocking This label is used by an internal tool
Milestone

Comments

@rafikiassumani-msft
Copy link
Contributor

rafikiassumani-msft commented Jun 2, 2022

Today we detect if you allow parallel hub invocations and throw if you don't when trying to use the feature. This doesn't work if you use IHubContext in the Hub, or if you have multiple waiting results for the same connections Hubs.
This is also especially bad in OnConnectedAsync because that's a special method that runs before the receive loop starts, we need to throw/unblock/warn etc. for this

@rafikiassumani-msft rafikiassumani-msft changed the title in Hub methods can soft-lock the connection Hub methods can soft-lock the connection Jun 2, 2022
@rafikiassumani-msft rafikiassumani-msft added the area-signalr Includes: SignalR clients and servers label Jun 2, 2022
@rafikiassumani-msft rafikiassumani-msft added this to the .NET 7 Planning milestone Jun 2, 2022
@ghost
Copy link

ghost commented Jun 2, 2022

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@rafikiassumani-msft rafikiassumani-msft added blocked The work on this issue is blocked due to some dependency severity-blocking This label is used by an internal tool and removed blocked The work on this issue is blocked due to some dependency labels Aug 9, 2022
@BrennanConroy
Copy link
Member

BrennanConroy commented Aug 22, 2022

The biggest issue with this is resolved.

What remains is using an injected IHubContext<THub> in the Hub can still cause issues.

@ghost

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers severity-blocking This label is used by an internal tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants