Skip to content

Scrub File prefix from internal File*Result types #36666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pranavkm opened this issue Sep 17, 2021 · 1 comment
Closed

Scrub File prefix from internal File*Result types #36666

pranavkm opened this issue Sep 17, 2021 · 1 comment
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Priority:1 Work that is critical for the release, but we could probably ship without
Milestone
.NET 7 Planning

Comments

@pranavkm
Copy link
Contributor

As part of #34296, we added Results.Stream, Results.File etc as we thought the existing names were less descriptive. However the PR did not rename the implementing types. While they're non-public, they appear in log messages e.g:

info: Microsoft.AspNetCore.Http.Result.FileStreamResult[1]
      Executing FileStreamResult, sending file with download name ''.

It would be nice to scrub these names too to match the Result types.
@pranavkm pranavkm added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Sep 17, 2021
@pranavkm
Copy link
Contributor Author

FYI @davidfowl

@rafikiassumani-msft rafikiassumani-msft added this to the .NET 7 Planning milestone Sep 17, 2021
@rafikiassumani-msft rafikiassumani-msft added the feature-minimal-actions Controller-like actions for endpoint routing label Dec 27, 2021
@rafikiassumani-msft rafikiassumani-msft mentioned this issue Jan 5, 2022
Closed
17 tasks
@rafikiassumani-msft rafikiassumani-msft added Priority:1 Work that is critical for the release, but we could probably ship without Cost:S labels Jan 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2022
@amcasey amcasey added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Priority:1 Work that is critical for the release, but we could probably ship without
Projects
None yet
Milestone
.NET 7 Planning
Development

No branches or pull requests
3 participants
@pranavkm @amcasey @rafikiassumani-msft