Skip to content

Commit fb93028

Browse files
authored
Synchronize KestrelTrace next-id comments (#49964)
* Synchronize KestrelTrace next-id comments * Make comment self-documenting * Update comments to reflect that KestrelTrace has split into separate loggers
1 parent 76bb69a commit fb93028

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.BadRequests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@ private static partial class BadRequestsLog
5353
[LoggerMessage(54, LogLevel.Debug, @"Connection id ""{ConnectionId}"": Invalid content received on connection. Possible incorrect HTTP version detected. Expected {ExpectedHttpVersion} but received {DetectedHttpVersion}.", EventName = "PossibleInvalidHttpVersionDetected", SkipEnabledCheck = true)]
5454
public static partial void PossibleInvalidHttpVersionDetected(ILogger logger, string connectionId, string expectedHttpVersion, string detectedHttpVersion);
5555

56-
// Highest shared ID is 63. New consecutive IDs start at 64
56+
// IDs prior to 64 are reserved for back compat (the various KestrelTrace loggers used to share a single sequence)
5757
}
5858
}

src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.Connections.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,6 @@ private static partial class ConnectionsLog
9797
[LoggerMessage(39, LogLevel.Debug, @"Connection id ""{ConnectionId}"" accepted.", EventName = "ConnectionAccepted")]
9898
public static partial void ConnectionAccepted(ILogger logger, string connectionId);
9999

100-
// Highest shared ID is 63. New consecutive IDs start at 64
100+
// IDs prior to 64 are reserved for back compat (the various KestrelTrace loggers used to share a single sequence)
101101
}
102102
}

src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.General.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,6 @@ private static partial class GeneralLog
107107
[LoggerMessage(66, LogLevel.Debug, @"Connection id ""{ConnectionId}"", Request id ""{TraceIdentifier}"": The request was aborted by the client.", EventName = "RequestAborted")]
108108
public static partial void RequestAbortedException(ILogger logger, string connectionId, string traceIdentifier);
109109

110-
// Highest shared ID is 66. New consecutive IDs start at 67
110+
// IDs prior to 64 are reserved for back compat (the various KestrelTrace loggers used to share a single sequence)
111111
}
112112
}

src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.Http2.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,6 @@ private static partial class Http2Log
129129
[LoggerMessage(63, LogLevel.Critical, @"The event loop in connection {ConnectionId} failed unexpectedly.", EventName = "Http2UnexpectedConnectionQueueError")]
130130
public static partial void Http2UnexpectedConnectionQueueError(ILogger logger, string connectionId, Exception ex);
131131

132-
// Highest shared ID is 63. New consecutive IDs start at 64
132+
// IDs prior to 64 are reserved for back compat (the various KestrelTrace loggers used to share a single sequence)
133133
}
134134
}

src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelTrace.Http3.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,6 @@ private static partial class Http3Log
101101
[LoggerMessage(53, LogLevel.Debug, @"Connection id ""{ConnectionId}"": GOAWAY stream ID {GoAwayStreamId}.", EventName = "Http3GoAwayHighestOpenedStreamId")]
102102
public static partial void Http3GoAwayStreamId(ILogger logger, string connectionId, long goAwayStreamId);
103103

104-
// Highest shared ID is 63. New consecutive IDs start at 64
104+
// IDs prior to 64 are reserved for back compat (the various KestrelTrace loggers used to share a single sequence)
105105
}
106106
}

0 commit comments

Comments
 (0)