Cleanups

Author: javiercn

src/Components/Endpoints/test/RazorComponentEndpointDataSourceTest.cs

@@ -7,7 +7,6 @@
 using Microsoft.AspNetCore.Components.Web;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.AspNetCore.Routing.Patterns;
-//using Microsoft.AspNetCore.Routing.Patterns;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 

src/Http/Http.Abstractions/src/Routing/RouteValueDictionary.cs

@@ -902,7 +902,11 @@ private static void ValidatePropertyNames(Type type, PropertyHelper[] properties
 
                 if (names.TryGetValue(property.Name, out var duplicate))
                 {
-                    var message = $"The type '{type.FullName}' defines properties '{property.Name}' and '{duplicate.Name}' which differ only by casing. This is not supported by {nameof(RouteValueDictionary)} which uses case-insensitive comparisons.";
+                    var message = Resources.FormatRouteValueDictionary_DuplicatePropertyName(
+                        type.FullName,
+                        property.Name,
+                        duplicate.Name,
+                        nameof(RouteValueDictionary));
                     throw new InvalidOperationException(message);
                 }
 

src/Http/Routing/src/ParameterPolicyActivator.cs

@@ -5,6 +5,9 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Reflection;
+#if COMPONENTS
+using Microsoft.AspNetCore.Components.Routing;
+#endif
 using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.AspNetCore.Routing;
@@ -37,12 +40,8 @@ internal static class ParameterPolicyActivator
             {
                 // Error if type is not a parameter policy
                 throw new RouteCreationException(
-#if !COMPONENTS
                     Resources.FormatDefaultInlineConstraintResolver_TypeNotConstraint(
                         parameterPolicyType, parameterPolicyKey, typeof(T).Name));
-#else
-                    $"The constraint type '{parameterPolicyType}' which is mapped to constraint key '{parameterPolicyKey}' must implement the '{typeof(T).Name}' interface.");
-#endif
             }
 
             // Return null if type is parameter policy but is not the exact type
@@ -122,12 +121,8 @@ private static IParameterPolicy CreateParameterPolicy(IServiceProvider? serviceP
             if (matchingConstructors.Count == 0)
             {
                 throw new RouteCreationException(
-#if !COMPONENTS
                     Resources.FormatDefaultInlineConstraintResolver_CouldNotFindCtor(
                         parameterPolicyType.Name, arguments.Length));
-#else
-                $"Could not find a constructor for constraint type '{parameterPolicyType.Name}' with the following number of parameters: {arguments.Length}.");
-#endif
             }
             else
             {
@@ -187,13 +182,8 @@ private static ConstructorInfo GetLongestConstructor(List<ConstructorInfo> const
         if (multipleBestLengthFound)
         {
             throw new RouteCreationException(
-#if !COMPONENTS
                 Resources.FormatDefaultInlineConstraintResolver_AmbiguousCtors(
                     parameterPolicyType.Name, longestLength));
-#else
-                $"The constructor to use for activating the constraint type '{parameterPolicyType.Name}' " +
-                $"is ambiguous. Multiple constructors were found with the following number of parameters: {longestLength}.");
-#endif
         }
 
         return longest!;