Skip to content

Commit efeb9cf

Browse files
committed
Update tests to use subtests.
1 parent 6dada01 commit efeb9cf

File tree

2 files changed

+35
-31
lines changed

2 files changed

+35
-31
lines changed

gotests/process/process_test.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,12 @@ func TestRun(t *testing.T) {
5151
},
5252
}
5353
for _, tt := range tests {
54-
out := &bytes.Buffer{}
55-
Run(out, tt.args, tt.opts)
56-
if got := out.String(); got != tt.want {
57-
t.Errorf("%q. Run() =\n%v, want\n%v", tt.name, got, tt.want)
58-
}
54+
t.Run(tt.name, func(t *testing.T) {
55+
out := &bytes.Buffer{}
56+
Run(out, tt.args, tt.opts)
57+
if got := out.String(); got != tt.want {
58+
t.Errorf("Run() =\n%v, want\n%v", got, tt.want)
59+
}
60+
})
5961
}
6062
}

gotests_test.go

+28-26
Original file line numberDiff line numberDiff line change
@@ -509,33 +509,35 @@ func TestGenerateTests(t *testing.T) {
509509
t.Fatalf("ioutil.TempDir: %v", err)
510510
}
511511
for _, tt := range tests {
512-
gts, err := GenerateTests(tt.args.srcPath, &Options{
513-
Only: tt.args.only,
514-
Exclude: tt.args.excl,
515-
Exported: tt.args.exported,
516-
PrintInputs: tt.args.printInputs,
517-
Subtests: tt.args.subtests,
518-
Importer: func() types.Importer { return tt.args.importer },
512+
t.Run(tt.name, func(t *testing.T) {
513+
gts, err := GenerateTests(tt.args.srcPath, &Options{
514+
Only: tt.args.only,
515+
Exclude: tt.args.excl,
516+
Exported: tt.args.exported,
517+
PrintInputs: tt.args.printInputs,
518+
Subtests: tt.args.subtests,
519+
Importer: func() types.Importer { return tt.args.importer },
520+
})
521+
if (err != nil) != tt.wantErr {
522+
t.Errorf("GenerateTests(%v) error = %v, wantErr %v", tt.args.srcPath, err, tt.wantErr)
523+
return
524+
}
525+
if (len(gts) == 0) != tt.wantNoTests {
526+
t.Errorf("GenerateTests(%v) returned no tests", tt.args.srcPath)
527+
return
528+
}
529+
if (len(gts) > 1) != tt.wantMultipleTests {
530+
t.Errorf("GenerateTests(%v) returned too many tests", tt.args.srcPath)
531+
return
532+
}
533+
if tt.wantNoTests || tt.wantMultipleTests {
534+
return
535+
}
536+
if got := string(gts[0].Output); got != tt.want {
537+
t.Errorf("GenerateTests(%v) = \n%v, want \n%v", tt.args.srcPath, got, tt.want)
538+
outputResult(t, tmp, tt.name, gts[0].Output)
539+
}
519540
})
520-
if (err != nil) != tt.wantErr {
521-
t.Errorf("%q. GenerateTests(%v) error = %v, wantErr %v", tt.name, tt.args.srcPath, err, tt.wantErr)
522-
continue
523-
}
524-
if (len(gts) == 0) != tt.wantNoTests {
525-
t.Errorf("%q. GenerateTests(%v) returned no tests", tt.name, tt.args.srcPath)
526-
continue
527-
}
528-
if (len(gts) > 1) != tt.wantMultipleTests {
529-
t.Errorf("%q. GenerateTests(%v) returned too many tests", tt.name, tt.args.srcPath)
530-
continue
531-
}
532-
if tt.wantNoTests || tt.wantMultipleTests {
533-
continue
534-
}
535-
if got := string(gts[0].Output); got != tt.want {
536-
t.Errorf("%q. GenerateTests(%v) = \n%v, want \n%v", tt.name, tt.args.srcPath, got, tt.want)
537-
outputResult(t, tmp, tt.name, gts[0].Output)
538-
}
539541
}
540542
}
541543

0 commit comments

Comments
 (0)