refactor: simplify handlebars generators #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://727.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
|
An automated preview of the documentation is available at https://727.mrdocs.prtest2.cppalliance.org/index.html |
Apart from the DocVisitor, the Adoc and HTML generators are nearly 100% duplicated code. This is the main reason the HTML Generator is always behind the Adoc Generator: simple features were not duplicated in the HTML generator. This even justified cppalliance#656, where we would temporarily remove the HTML generator. This commit unifies the standard code to remove duplicated code, simplify maintenance, and ensure that both generators always have access to the same features. In passing, many missing features in the HTML generator are now available. fix cppalliance#656
alandefreitas
force-pushed
the
hbs-gen-sync
branch
from
fd3ad08 to
5e12358
Compare
|
An automated preview of the documentation is available at https://727.mrdocs.prtest2.cppalliance.org/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the DocVisitor, the Adoc and HTML generators are nearly 100% duplicated code.
This is the main reason the HTML Generator is always behind the Adoc Generator: simple features were not duplicated in the HTML generator. This even justified #656, where we would temporarily remove the HTML generator.
This commit unifies the standard code to remove 7000+ lines of duplicated code, simplify maintenance, and ensure that both generators always have access to the same features.
In passing, many missing features in the HTML generator are now available.
fix #656