From 05299c733ff42623abf003b1d56a63939d7fa4b0 Mon Sep 17 00:00:00 2001 From: Tom Date: Mon, 24 Aug 2020 16:27:09 +0200 Subject: [PATCH] Eclipse compiler: close the StandardJavaFileManager Compare #98. --- .../plexus/compiler/eclipse/EclipseJavaCompiler.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java b/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java index 63666348..9726cf37 100644 --- a/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java +++ b/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java @@ -400,9 +400,6 @@ public void report( Diagnostic diagnostic ) { charset = Charset.defaultCharset(); } - StandardJavaFileManager manager = - compiler.getStandardFileManager( messageCollector, defaultLocale, charset ); - if ( getLogger().isDebugEnabled() ) { getLogger().debug( "ecj: using character set " + charset.displayName() ); @@ -410,9 +407,9 @@ public void report( Diagnostic diagnostic ) getLogger().debug( "ecj input source files: " + allSources ); } - Iterable units = manager.getJavaFileObjectsFromStrings( allSources ); - try - { + try ( StandardJavaFileManager manager = + compiler.getStandardFileManager( messageCollector, defaultLocale, charset ) ) { + Iterable units = manager.getJavaFileObjectsFromStrings( allSources ); success = Boolean.TRUE.equals( compiler.getTask( devNull, manager, messageCollector, args, null, units ).call() ); }