Skip to content

Commit 382f633

Browse files
Bryan C. Millscodebien
Bryan C. Mills
authored andcommitted
dashboard: disable failing repos on misconfigured builders
Updates golang/go#32836 Updates golang/go#31567 Updates golang/go#11811 Change-Id: I5443b61cf7732abf906ce2e93eca5408579a55c8 Reviewed-on: https://go-review.googlesource.com/c/build/+/192327 Run-TryBot: Bryan C. Mills <bcmills@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org>
1 parent 5e0d1ba commit 382f633

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

dashboard/builders.go

+24
Original file line numberDiff line numberDiff line change
@@ -2050,6 +2050,15 @@ func init() {
20502050
Name: "illumos-amd64-joyent",
20512051
HostType: "host-illumos-amd64-joyent",
20522052
MinimumGoVersion: types.MajorMinor{1, 13},
2053+
buildsRepo: func(repo, branch, goBranch string) bool {
2054+
if repo == "review" {
2055+
// '.git/hooks/pre-commit' cannot be executed on this builder,
2056+
// which causes the x/review tests to fail.
2057+
// (https://golang.org/issue/32836)
2058+
return false
2059+
}
2060+
return defaultBuildsRepoPolicy(repo, branch, goBranch)
2061+
},
20532062
})
20542063
addBuilder(BuildConfig{
20552064
Name: "linux-ppc64-buildlet",
@@ -2120,6 +2129,15 @@ func init() {
21202129
HostType: "host-dragonfly-amd64-tdfbsd",
21212130
shouldRunDistTest: noTestDir,
21222131
SkipSnapshot: true,
2132+
buildsRepo: func(repo, branch, goBranch string) bool {
2133+
if repo == "review" {
2134+
// '.git/hooks/pre-commit' cannot be executed on this builder,
2135+
// which causes the x/review tests to fail.
2136+
// (https://golang.org/issue/32836)
2137+
return false
2138+
}
2139+
return defaultBuildsRepoPolicy(repo, branch, goBranch)
2140+
},
21232141
})
21242142
addBuilder(BuildConfig{
21252143
Name: "freebsd-arm-paulzhol",
@@ -2195,6 +2213,12 @@ func init() {
21952213
// The x/net package wasn't working in Go 1.12; AIX folk plan to have
21962214
// it ready by Go 1.13. See https://golang.org/issue/31564#issuecomment-484786144
21972215
return atLeastGo1(branch, 13) && atLeastGo1(goBranch, 13)
2216+
case "review", "tools", "tour":
2217+
// The PATH on this builder is misconfigured in a way that causes tests
2218+
// in x/review, x/tools and x/tour to fail
2219+
// (https://golang.org/issue/31567).
2220+
// Skip those until the builder is fixed.
2221+
return false
21982222
}
21992223
return atLeastGo1(branch, 12) && atLeastGo1(goBranch, 12) && defaultBuildsRepoPolicy(repo, branch, goBranch)
22002224
},

0 commit comments

Comments
 (0)