add skip hooks parameter

Author: jcabrerizo

src/commands/create-issue.ts

@@ -3,10 +3,11 @@ import fs from "node:fs";
 import CreateIssueOpt from "../commandOpts/create-issue.js";
 import {SleekCommand} from "../sleek-command.js";
 import CreateIssueService from "../services/create-issue.js";
-import {IssueData} from "../types/issue.js";
+import {ChartAutoCorrection, IssueData} from "../types/issue.js";
 import SchemaValidationService from "../services/schemaValidation.js";
 import ChartValidatorService from "../services/validate.js";
 import {execSync} from "child_process";
+import {ValidateOptions} from "../types/validate.js";
 
 
 export class CreateIssue extends SleekCommand {
@@ -36,7 +37,10 @@ export class CreateIssue extends SleekCommand {
         const chartTag = addonData.helmChartUrl.lastIndexOf(':') ? `${addonData.helmChartUrl.substring(addonData.helmChartUrl.lastIndexOf(':')+1)}` : ''
         const charPath=await this.pullHelmChart(addonData.name, chartTag, repo)
         const validatorService = new ChartValidatorService(this, charPath);
-        const validatorServiceResp = await validatorService.validate();
+        const validateOps: ValidateOptions ={
+            skipHooksValidation: inputDataParsed.chartAutoCorrection.includes(ChartAutoCorrection.hooks)
+        }
+        const validatorServiceResp = await validatorService.validate(validateOps);
         // todo: if validatorService exits when errors, not need to handle here !success
         if(!validatorServiceResp.success){
             this.error(validatorServiceResp.error?.input!, validatorServiceResp.error?.options )

src/commands/validate.ts

@@ -47,6 +47,7 @@ export default class Validate extends SleekCommand {
     protocol: Flags.string({description: "Protocol of the helm hosting to use", exclusive: ['file', 'helmUrl'], char:'p'}),
     version: Flags.string({description: "Version of the addon to validate", exclusive: ['file'], char:'v'}),
     addonName: Flags.string({description: "Name of the addon"}),
+    skipHooks: Flags.boolean({description: "Skip helm hooks validation", default:false}),
     extended: Flags.boolean({description: "Run extended validation", hidden: true, char:'e'}), // triggers security and extended checks. NEEDS THE CONTAINER IMAGE FOR THE ADDON
   }
 
@@ -67,6 +68,7 @@ export default class Validate extends SleekCommand {
     if (flags.addonName) {
       addonName = flags.addonName;
     }
+    const skipHooksValidation = flags.skipHooks;
     if (args.helmUrl || flags.helmUrl) {
       // JD decompose url, pull  and validate
       const repoUrlInput = args.helmUrl || flags.helmUrl;
@@ -103,7 +105,7 @@ export default class Validate extends SleekCommand {
     const chartPath = await helmManager.pullAndUnzipChart(repoUrl!, repoProtocol!, versionTag!, addonName);
 
     const validatorService = new ChartValidatorService(this, chartPath);
-    const validatorServiceResp = await validatorService.validate();
+    const validatorServiceResp = await validatorService.validate({ skipHooksValidation });
 
     this.log(validatorServiceResp.body);
 

src/services/validate.ts

@@ -7,6 +7,16 @@ import {spawnSync} from "child_process";
 import {BaseService} from "./base-service.js";
 import {ServiceResponse} from "../types/service.js";
 import {SleekCommand} from "../sleek-command.js";
+import {ValidateOptions} from "../types/validate.js";
+
+export const SuccessResponse:ServiceResponse<string> = {
+  success: true,
+};
+
+export const ValidationSkipped:ServiceResponse<string> = {
+  success: true,
+  body:'validation skipped'
+};
 
 export default class ChartValidatorService extends BaseService {
   // this will always be a local filepath
@@ -21,9 +31,9 @@ export default class ChartValidatorService extends BaseService {
 
   }
 
-  public async validate(): Promise<ServiceResponse<any>> {
+  public async validate(ops: ValidateOptions): Promise<ServiceResponse<any>> {
     const capabilities = await this.findCapabilities();
-    const hooks = await this.findHooks();
+    const hooks = ops.skipHooksValidation ? ValidationSkipped : await this.findHooks();
     const dependencies = await this.findDependencies();
 
     let response: ServiceResponse<string> = {
@@ -82,14 +92,10 @@ export default class ChartValidatorService extends BaseService {
       encoding: "utf-8"
     });
 
-    let response: ServiceResponse<string>;
-
     if (capabilities.stdout === "") {
-      response = {
-        success: true,
-      }
+      return SuccessResponse
     } else {
-      response = {
+      return  {
         success: false,
         body: "Unsupported system Capabilities are used in chart.",
         error: {
@@ -101,20 +107,16 @@ export default class ChartValidatorService extends BaseService {
         }
       }
     }
-
-    return response;
   }
 
   private async findHooks(): Promise<ServiceResponse<string>> {
     const hooks = spawnSync('grep', ['-Rile', '".Hooks"', this.toValidate], {shell: true, encoding: "utf-8"});
 
     let response: ServiceResponse<string>;
     if (hooks.stdout === "") {
-      response = {
-        success: true,
-      }
+      return SuccessResponse
     } else {
-      response = {
+      return {
         success: false,
         body: "Unsupported system Hooks are used in chart.",
         error: {
@@ -126,8 +128,6 @@ export default class ChartValidatorService extends BaseService {
         }
       }
     }
-
-    return response;
   }
 
   private async findDependencies(): Promise<ServiceResponse<string>> {
@@ -150,11 +150,9 @@ export default class ChartValidatorService extends BaseService {
     const allDepsFiles = dependencies.every(dep => dep.includes('file://'));
 
     if (allDepsFiles) {
-      response = {
-        success: true,
-      }
+      return SuccessResponse
     } else {
-      response = {
+      return {
         success: false,
         body: "Not all dependencies reside in the main chart.",
         error: {
@@ -166,7 +164,5 @@ export default class ChartValidatorService extends BaseService {
         }
       }
     }
-
-    return response;
   }
 }

src/types/issue.d.ts

@@ -5,8 +5,13 @@ export type AddonData = {
     helmChartUrlProtocol: string,
     containerImagesUrls: string[],
 };
+export enum ChartAutoCorrection {
+    hooks = 'hooks',
+    releaseService = 'releaseService',
+}
 
 export type IssueData = {
     addon: AddonData;
     sellerMarketPlaceAlias: string,
+    chartAutoCorrection: ChartAutoCorrection[]
 };

src/types/validate.d.ts

@@ -0,0 +1,3 @@
+export type ValidateOptions = {
+    skipHooksValidation:boolean
+}