Breaking change in 2.0.1

[ThomWright]

yarn why http-proxy-middleware OR npm ls http-proxy-middleware output (mask private folder names with *****)

public-api@1.1.0 *****/public-api
└── http-proxy-middleware@2.0.1

• I understand project setup issues should be asked on StackOverflow or in GitHub Discussions.
• I updated to latest http-proxy-middleware.

Describe the bug (be clear and concise)

A breaking change was released with 2.0.1. The response type for onProxyRes used to be express.Response, but is now http.Response. This should have been a major version change.

Step-by-step reproduction instructions

1. Install 2.0.0. Use e.g. `res.status(200).send()` in `onProxyRes`.
2. Update to 2.0.1. See red squiggly lines. Be sad.

Expected behavior (be clear and concise)

No breaking changes in patch version changes.

What http-proxy-middleware configuration are you using?

N/A

What OS/version and node/version are you seeing the problem?

N/A

Additional context (optional)

No response

[artemtam]

Can confirm we have our types broken in 2.0.1. In 2.0.0 the onProxyReq definition is the following:

(proxyReq: http.ClientRequest, req: Request, res: Response) => void;

In 2.0.1 it is changed to:

(proxyReq: http.ClientRequest, req: http.IncomingMessage, res: http.ServerResponse, options: httpProxy.ServerOptions) => void;

It is definitely a breaking change, so it must have been a major version bump. Also, it is unclear if it is just a wrong type definition, or the real implementation of onProxyReq has changed?

[asself]

same issue，why minor version upgrade lead to break change?

[rcollette]

Further, objects that are appended to the Request type, such as Okta's OIDC middleware userContext, are not recognized with IncomingMessage. Granted, these things should be tacked on to locals, but... even req.Body is no longer recognized as a property of IncomingMessage.

I'm rolling back to 2.0