Implement derive macro for Arbitrary (rust-lang#2016)

Introduce a derive macro that allows users to annotate their structs and enums with `#[derive(kani::Arbitray)]`. This will allow users to easily generate implementation of the Arbitrary types for their custom structs and enums when their arbitrary value is a combination of its fields arbitrary values.

Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>

Author: celinval

Cargo.lock

@@ -542,6 +542,8 @@ dependencies = [
 name = "kani_macros"
 version = "0.17.0"
 dependencies = [
+ "proc-macro-error",
+ "proc-macro2",
  "quote",
  "syn",
 ]

library/kani_macros/Cargo.toml

@@ -12,5 +12,7 @@ publish = false
 proc-macro = true
 
 [dependencies]
+proc-macro2 = "1.0"
+proc-macro-error = "1.0.4"
 quote = "1.0.20"
 syn = { version = "1.0.98", features = ["full"] }

library/kani_macros/src/derive.rs

@@ -0,0 +1,168 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! This module provides Kani's `derive` macro for `Arbitrary`.
+//!
+//! ```
+//! use kani::Arbitrary;
+//!
+//! #[derive(Arbitrary)]
+//! struct S;
+//!
+//! ```
+use proc_macro2::{Ident, Span, TokenStream};
+use proc_macro_error::abort;
+use quote::{quote, quote_spanned};
+use syn::spanned::Spanned;
+use syn::{
+    parse_macro_input, parse_quote, Data, DataEnum, DeriveInput, Fields, GenericParam, Generics,
+    Index,
+};
+
+pub fn expand_derive_arbitrary(item: proc_macro::TokenStream) -> proc_macro::TokenStream {
+    let derive_item = parse_macro_input!(item as DeriveInput);
+    let item_name = &derive_item.ident;
+
+    // Add a bound `T: Arbitrary` to every type parameter T.
+    let generics = add_trait_bound(derive_item.generics);
+    // Generate an expression to sum up the heap size of each field.
+    let (impl_generics, ty_generics, where_clause) = generics.split_for_impl();
+
+    let body = fn_any_body(&item_name, &derive_item.data);
+    let expanded = quote! {
+        // The generated implementation.
+        impl #impl_generics kani::Arbitrary for #item_name #ty_generics #where_clause {
+            fn any() -> Self {
+                #body
+            }
+        }
+    };
+    proc_macro::TokenStream::from(expanded)
+}
+
+/// Add a bound `T: Arbitrary` to every type parameter T.
+fn add_trait_bound(mut generics: Generics) -> Generics {
+    generics.params.iter_mut().for_each(|param| {
+        if let GenericParam::Type(type_param) = param {
+            type_param.bounds.push(parse_quote!(kani::Arbitrary));
+        }
+    });
+    generics
+}
+
+/// Generate the body of the function `any()`.
+/// This will create the non-deterministic object.
+/// E.g.:
+/// ```
+/// #[derive(Arbitrary)]
+/// struct Point { x: u8, y: u8 }
+/// ```
+/// will generate the following body for `fn any()`:
+/// ```
+/// fn any() -> Self {
+///    Self { x: kani::any(), y: kani::any() }
+/// }
+/// ```
+fn fn_any_body(ident: &Ident, data: &Data) -> TokenStream {
+    match data {
+        Data::Struct(struct_data) => init_symbolic_item(ident, &struct_data.fields),
+        Data::Enum(enum_data) => fn_any_enum(ident, enum_data),
+        Data::Union(_) => {
+            abort!(Span::call_site(), "Cannot derive `Arbitrary` for `{}` union", ident;
+                note = ident.span() =>
+                "`#[derive(Arbitrary)]` cannot be used for unions such as `{}`", ident
+            )
+        }
+    }
+}
+
+/// Generate an item initialization where an item can be a struct or a variant.
+/// For named fields, this will generate: `Item { field1: kani::any(), field2: kani::any(), .. }`
+/// For unnamed fields, this will generate: `Item (kani::any(), kani::any(), ..)`
+/// For unit field, generate an empty initialization.
+fn init_symbolic_item(ident: &Ident, fields: &Fields) -> TokenStream {
+    match fields {
+        Fields::Named(ref fields) => {
+            // Use the span of each `syn::Field`. This way if one of the field types does not
+            // implement `Arbitrary` then the compiler's error message underlines which field it
+            // is. An example is shown in the readme of the parent directory.
+            let init = fields.named.iter().map(|field| {
+                let name = &field.ident;
+                quote_spanned! {field.span()=>
+                    #name: kani::any()
+                }
+            });
+            quote! {
+                #ident {#( #init,)*}
+            }
+        }
+        Fields::Unnamed(ref fields) => {
+            // Expands to an expression like
+            // Self(kani::any(), kani::any(), ..., kani::any());
+            let init = fields.unnamed.iter().map(|field| {
+                quote_spanned! {field.span()=>
+                    kani::any()
+                }
+            });
+            quote! {
+                #ident(#( #init,)*)
+            }
+        }
+        Fields::Unit => {
+            quote! {
+                #ident
+            }
+        }
+    }
+}
+
+/// Generate the body of the function `any()` for enums. The cases are:
+/// 1. For zero-variants enumerations, this will encode a `panic!()` statement.
+/// 2. For one or more variants, the code will be something like:
+/// ```
+/// # enum Enum{
+/// #    WithoutData,
+/// #    WithUnNamedData(i32),
+/// #    WithNamedData{ i: i32},
+/// # }
+/// #
+/// # impl kani::Arbitrary for Enum {
+/// #     fn any() -> Self {
+///         match kani::any() {
+///             0 => Enum::WithoutData,
+///             1 => Enum::WithUnNamedData(kani::any()),
+///             _ => Enum::WithNamedData {i: kani::any()},
+///         }
+/// #    }
+/// # }
+/// ```
+fn fn_any_enum(ident: &Ident, data: &DataEnum) -> TokenStream {
+    if data.variants.is_empty() {
+        let msg = format!(
+            "Cannot create symbolic enum `{}`. Enums with zero-variants cannot be instantiated",
+            ident
+        );
+        quote! {
+            panic!(#msg)
+        }
+    } else {
+        let arms = data.variants.iter().enumerate().map(|(idx, variant)| {
+            let init = init_symbolic_item(&variant.ident, &variant.fields);
+            if idx + 1 < data.variants.len() {
+                let index = Index::from(idx);
+                quote! {
+                    #index => #ident::#init,
+                }
+            } else {
+                quote! {
+                    _ => #ident::#init,
+                }
+            }
+        });
+
+        quote! {
+            match kani::any() {
+                #(#arms)*
+            }
+        }
+    }
+}

library/kani_macros/src/lib.rs

@@ -8,8 +8,11 @@
 // So we have to enable this on the commandline (see kani-rustc) with:
 //   RUSTFLAGS="-Zcrate-attr=feature(register_tool) -Zcrate-attr=register_tool(kanitool)"
 
+mod derive;
+
 // proc_macro::quote is nightly-only, so we'll cobble things together instead
 use proc_macro::TokenStream;
+use proc_macro_error::proc_macro_error;
 #[cfg(kani)]
 use {
     quote::quote,
@@ -148,3 +151,10 @@ pub fn stub(attr: TokenStream, item: TokenStream) -> TokenStream {
     result.extend(item);
     result
 }
+
+/// Allow users to auto generate Arbitrary implementations by using `#[derive(Arbitrary)]` macro.
+#[proc_macro_error]
+#[proc_macro_derive(Arbitrary)]
+pub fn derive_arbitrary(item: TokenStream) -> TokenStream {
+    derive::expand_derive_arbitrary(item)
+}

tests/ui/derive-arbitrary/empty_enum/empty_enum.rs

@@ -0,0 +1,13 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that Kani can automatically derive an empty Arbitrary enum but the method `panic!()`
+//! when invoked since an empty enumeration cannot be instantiated.
+
+#[derive(kani::Arbitrary)]
+enum Empty {}
+
+#[kani::proof]
+fn check_no_variants() {
+    let _e: Empty = kani::any();
+    unreachable!();
+}

tests/ui/derive-arbitrary/empty_enum/expected

@@ -0,0 +1,2 @@
+Checking harness check_no_variants...
+Failed Checks: Cannot create symbolic enum `Empty`. Enums with zero-variants cannot be instantiated

tests/ui/derive-arbitrary/empty_struct/empty_struct.rs

@@ -0,0 +1,17 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that Kani can automatically derive Arbitrary for empty structs.
+
+#[derive(kani::Arbitrary)]
+struct Void;
+
+#[derive(kani::Arbitrary)]
+struct Void2(());
+
+#[derive(kani::Arbitrary)]
+struct VoidOfVoid(Void, Void2);
+
+#[kani::proof]
+fn check_arbitrary_point() {
+    let _v: VoidOfVoid = kani::any();
+}

tests/ui/derive-arbitrary/empty_struct/expected

@@ -0,0 +1,2 @@
+Checking harness check_arbitrary_point...
+VERIFICATION:- SUCCESSFUL

tests/ui/derive-arbitrary/enum/enum.rs

@@ -0,0 +1,50 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that Kani can automatically derive Arbitrary enums.
+//! An arbitrary enum should always generate a valid arbitrary variant.
+
+extern crate kani;
+use kani::cover;
+
+#[derive(kani::Arbitrary)]
+enum Wrapper {
+    Empty,
+    Bool(bool),
+    Char { c: char },
+}
+
+#[kani::proof]
+fn check_enum_wrapper() {
+    match kani::any::<Wrapper>() {
+        Wrapper::Empty => cover!(),
+        Wrapper::Bool(b) => {
+            cover!(b as u8 == 0);
+            cover!(b as u8 == 1);
+            assert!(b as u8 == 0 || b as u8 == 1);
+        }
+        Wrapper::Char { c } => {
+            assert!(c <= char::MAX);
+            cover!(c == 'a');
+            cover!(c == '1');
+        }
+    }
+}
+
+#[derive(kani::Arbitrary, Copy, Clone)]
+enum Comparison {
+    Less = -1,
+    Equal = 0,
+    Greater = 1,
+}
+
+#[kani::proof]
+fn check_comparison() {
+    let comp: Comparison = kani::any();
+    let disc = comp as i8;
+    assert!(disc >= -1 && disc <= 1);
+    match comp {
+        Comparison::Less => assert!(disc == -1),
+        Comparison::Equal => assert!(disc == 0),
+        Comparison::Greater => assert!(disc == 1),
+    }
+}

tests/ui/derive-arbitrary/enum/expected

@@ -0,0 +1,16 @@
+Checking harness check_comparison...
+SUCCESS\
+"assertion failed: disc >= -1 && disc <= 1"
+
+SUCCESS\
+"assertion failed: disc == 1"
+
+SUCCESS\
+"assertion failed: disc == -1"
+
+SUCCESS\
+"assertion failed: disc == 0"
+
+
+Checking harness check_enum_wrapper...
+5 of 5 cover properties satisfied

tests/ui/derive-arbitrary/generic_struct/expected

@@ -0,0 +1,2 @@
+Checking harness check_arbitrary_point...
+6 of 6 cover properties satisfied

tests/ui/derive-arbitrary/generic_struct/generic_struct.rs

@@ -0,0 +1,24 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that Kani can automatically derive Arbitrary for structs with named fields.
+
+extern crate kani;
+
+use kani::cover;
+
+#[derive(kani::Arbitrary)]
+struct Point<X, Y> {
+    x: X,
+    y: Y,
+}
+
+#[kani::proof]
+fn check_arbitrary_point() {
+    let point: Point<i32, i8> = kani::any();
+    cover!(point.x > 0);
+    cover!(point.x < 0);
+    cover!(point.x == 0);
+    cover!(point.y > 0);
+    cover!(point.y < 0);
+    cover!(point.y == 0);
+}

tests/ui/derive-arbitrary/named_struct/expected

@@ -0,0 +1,2 @@
+Checking harness check_arbitrary_point...
+4 of 4 cover properties satisfied

tests/ui/derive-arbitrary/named_struct/named_struct.rs

@@ -0,0 +1,18 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that Kani can automatically derive Arbitrary for structs with named fields.
+
+#[derive(kani::Arbitrary)]
+struct Point {
+    x: i32,
+    y: i32,
+}
+
+#[kani::proof]
+fn check_arbitrary_point() {
+    let point: Point = kani::any();
+    kani::cover!(point.x > 0);
+    kani::cover!(point.x <= 0);
+    kani::cover!(point.y > 0);
+    kani::cover!(point.y <= 0);
+}

tests/ui/derive-arbitrary/non_arbitrary_field/expected

@@ -0,0 +1,6 @@
+error[E0277]: the trait bound `NotArbitrary: kani::Arbitrary` is not satisfied
+|\
+|     not_arbitrary: NotArbitrary,\
+|     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `kani::Arbitrary` is not implemented for `NotArbitrary`
+
+Error: "Failed to compile crate."

tests/ui/derive-arbitrary/non_arbitrary_field/non_arbitrary_field.rs

@@ -0,0 +1,20 @@
+// Copyright Kani Contributors
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+//! Check that there's a compilation error if user tries to use Arbitrary when one of the fields do
+//! not implement Arbitrary.
+
+struct NotArbitrary(u8);
+
+#[derive(kani::Arbitrary)]
+struct Arbitrary(u8);
+
+#[derive(kani::Arbitrary)]
+struct Wrapper {
+    arbitrary: Arbitrary,
+    not_arbitrary: NotArbitrary,
+}
+
+#[kani::proof]
+fn dead_harness() {
+    panic!("This shouldn't compile");
+}