-
Notifications
You must be signed in to change notification settings - Fork 17
Safety check creates SQL aggregating error #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The group by is actually completely redundant. |
I had to fix a couple more little bugs to make the test run. |
The changes applied in #197 were only applied to branch MOODLE_311_STABLE. To close also port these changes to master and MOODLE_310_STABLE. EDIT: And branch TOTARA_13. |
There are pull requests for master and _310 branches. I have tested theses branches on my local docker-dev. |
The pull requests are merged. The branches may be older. The scope of this issue is will focus on that SQL what we have done. Feel free to create a new issue to maybe close down some branches. There is still one branch remaining: |
Patches have been applied to master, MOODLE_310_STABLE, MOODLE_311_STABLE, and TOTARA_13 branches. |
The SQL query here https://github.com/catalyst/moodle-local_datacleaner/blob/MOODLE_311_STABLE/cli/lib.php#L106-L112
Uses a group by statement incorrectly. Changing the select to select distinct and removing the group by will resolve the issue.
The text was updated successfully, but these errors were encountered: