Skip to content

Commit 17ba32a

Browse files
committed
Remove some rerun-if-env-changed lines from build.rs.
Now that we appear to have a known-working fix for #526, we can investigate relaxing the fix. If #526 reappears, we now have a known-working state we can quickly revert to. Reports in #562 and #575 are that having rerun-if-env-changed=RUSTC and rerun-if-env-changed=RUSTC_WRAPPER are triggering spurious rebuilds in some situations, so remove these. In theory, cargo should already be aware of these environment variables. In practice, there were reports of build failures which had the appearance of using an older version of rustc with build.rs output from a newer version of rustc, and it wasn't clear what was happening. But, it's possible that #563 fixes the issue properly. So let's try removing these rerun-if-env-changed lines, and see if the problem resurfaces. And, rerun-if-env-changed=TARGET is explicitly documented as being unnecessary [here]. [here]: https://doc.rust-lang.org/cargo/reference/build-scripts.html
1 parent 1a9d8da commit 17ba32a

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

build.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,11 +147,6 @@ fn main() {
147147
println!("cargo:rerun-if-env-changed=CARGO_FEATURE_USE_LIBC");
148148
println!("cargo:rerun-if-env-changed=CARGO_FEATURE_RUSTC_DEP_OF_STD");
149149
println!("cargo:rerun-if-env-changed=CARGO_CFG_MIRI");
150-
println!("cargo:rerun-if-env-changed=CARGO_ENCODED_RUSTFLAGS");
151-
println!("cargo:rerun-if-env-changed=RUSTC");
152-
println!("cargo:rerun-if-env-changed=TARGET");
153-
println!("cargo:rerun-if-env-changed=RUSTC_WRAPPER");
154-
println!("cargo:rerun-if-env-changed=PROFILE");
155150
}
156151

157152
/// Link in the desired version of librustix_outline_{arch}.a, containing the

0 commit comments

Comments
 (0)