Skip to content

Suggestion: Github Actions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nulfrost opened this issue Apr 18, 2025 · 2 comments · May be fixed by #18
Open

Suggestion: Github Actions #16

nulfrost opened this issue Apr 18, 2025 · 2 comments · May be fixed by #18

Comments

@nulfrost
Copy link
Contributor

We already have pre-commit hooks but I feel like we could just limit this to just linting/formatting and keep tests (unit and integration) for a github action to run. Or just move everything to github actions that way we know for sure that something will get caught. (I've been guilty of just doing --no-verify since it's muscle memory at this point)
@FreedomWriter
Copy link
Collaborator

yeah, this is definitely another of those things that wasn't important when it was just me working on the project, but should 100% be implemented.

@nulfrost
Copy link
Contributor Author

Can make a draft PR for this and see what we want to cover in a github action vs something that pre-commit hooks run

@nulfrost nulfrost linked a pull request Apr 20, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: lint, format and test in github actions nulfrost/safe-skies-api
2 participants
@nulfrost @FreedomWriter