fix(lint/useRegexLiterals): handle useless escapes #5716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Conaclos
force-pushed
the
conaclos/useRegexLiterals-#5693
branch
2 times, most recently
from
714cf99 to
632f08a
Compare
CodSpeed Performance ReportMerging #5716 will not alter performanceComparing Summary
|
ematipico
approved these changes
Apr 22, 2025
chansuke
reviewed
Apr 22, 2025
crates/biome_js_analyze/src/lint/complexity/use_regex_literals.rs
Outdated
Show resolved
Hide resolved
siketyan
approved these changes
Apr 22, 2025
Conaclos
force-pushed
the
conaclos/useRegexLiterals-#5693
branch
from
632f08a to
f8b7cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #5693 (comment)
I took the opportunity of reviewing the entire process of escape/unescape.
I fixed many edge cases including:
Test Plan
I added new tests.