Skip to content

Support Lambda-Extension-Accept-Feature for extension registration #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mwudtke opened this issue May 29, 2024 · 3 comments · Fixed by #887
Closed

Support Lambda-Extension-Accept-Feature for extension registration #882

mwudtke opened this issue May 29, 2024 · 3 comments · Fixed by #887

Comments

@mwudtke
Copy link

mwudtke commented May 29, 2024

When calling the register API during extension initialization, there is an optional request header called Lambda-Extension-Accept-Feature that allows you to get the account ID associated with the Lambda function on the response body from the register API call documentation reference. The lambda-extension crate, however, has no way for consumers to add this header to the request, or to receive the accountId on the response body.

There should either be a way to opt-in to these "additional features" when registering extensions, or possibly even include the accountId by default.

Has this been considered before? Is there a preference by the maintainers for including something like that by default vs making it a parameter?

@calavera
Copy link
Contributor

Feel free to open a PR to support it. We'll appreciate the help.

@calavera
Copy link
Contributor

calavera commented Jun 1, 2024

I've implemented this in #887

Copy link

github-actions bot commented Jun 2, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants