Skip to content

VS shows documentation for attributes when writing the component tag #9133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pranavkm opened this issue Apr 5, 2019 · 11 comments
Closed

VS shows documentation for attributes when writing the component tag #9133

pranavkm opened this issue Apr 5, 2019 · 11 comments
Assignees
@NTaylorMullen
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel
Milestone
3.1.0-preview2

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 5, 2019

image

Reproduced using 3.0.0-preview4 SDK and d16.1stg
@pranavkm pranavkm added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-blazor Includes: Blazor, Razor Components labels Apr 5, 2019
@rynowak
Copy link
Member

rynowak commented Apr 5, 2019

The fix for this would be in WTE. They build the tooltip.

@mkArtakMSFT mkArtakMSFT added the External This is an issue in a component not contained in this repository. It is open for tracking purposes. label Apr 8, 2019
@mkArtakMSFT mkArtakMSFT added this to the 3.0.0-preview5 milestone Apr 8, 2019
@mkArtakMSFT
Copy link
Member

@danroth27 can you please follow up with the tooling team so that this can be fixed? Thanks!

@danroth27
Copy link
Member

Adding @NTaylorMullen since he was seeing something similar in VS Code as well.

@NTaylorMullen
Copy link

Ya there's a good chance the way we're generating bind, event handlers etc. TagHelperDescriptors may be resulting in this behavior. Would have to investigate more. Either way it's consistent in VSCode.

@rynowak
Copy link
Member

rynowak commented Apr 9, 2019

That's because you implemented tooltips the same thing WTE does.

IDK how we would generate different descriptors without redoing everything. What we generate is "correct" - but we don't like how that displays, so we should change how it displays.

@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview5, 3.0.0 Apr 15, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@danroth27
Copy link
Member

Assigning to Taylor as he still believe this is under our control.

@danroth27 danroth27 modified the milestones: 3.0.0, 3.0.0-preview8 May 18, 2019
@danroth27 danroth27 added bug This issue describes a behavior which is not expected - a bug. enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed cost: 0 External This is an issue in a component not contained in this repository. It is open for tracking purposes. bug This issue describes a behavior which is not expected - a bug. labels May 18, 2019
@danroth27 danroth27 removed their assignment May 18, 2019
@mkArtakMSFT mkArtakMSFT added the External This is an issue in a component not contained in this repository. It is open for tracking purposes. label Jun 25, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.0.0-preview8, 3.1.0 Jun 25, 2019
@mkArtakMSFT
Copy link
Member

This should be fixed already.

@NTaylorMullen
Copy link

This should be fixed already.

Wait really? When?

@mkArtakMSFT
Copy link
Member

@rynowak?

@rynowak
Copy link
Member

rynowak commented Aug 15, 2019

IDK LOL?

@rynowak rynowak reopened this Aug 15, 2019
@mkArtakMSFT mkArtakMSFT modified the milestones: 3.1.0, 3.1.0-preview1 Aug 19, 2019
@mkArtakMSFT
Copy link
Member

@NTaylorMullen please follow up on this. Let's either get this fixed, if we can do it on our own, or please follow up with the owners to get this fixed.

@danroth27 danroth27 mentioned this issue Sep 7, 2019
Closed
10 tasks
@mkArtakMSFT mkArtakMSFT added cost: S Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel and removed External This is an issue in a component not contained in this repository. It is open for tracking purposes. labels Sep 9, 2019
@danroth27 danroth27 added bug This issue describes a behavior which is not expected - a bug. and removed enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Sep 25, 2019
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Oct 16, 2019
Remove directive attribute completions from element completion list.
1d6f68c 
- This removes the excess amount of directive attribute completions that show up when completing a component.
- Added a test to verify directive attributes no longer show up in element completions.

dotnet/aspnetcore#9133
@NTaylorMullen NTaylorMullen mentioned this issue Oct 17, 2019
Merged
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Oct 18, 2019
Remove directive attribute completions from element completion list.
f072dc7 
- This removes the excess amount of directive attribute completions that show up when completing a component.
- Added a test to verify directive attributes no longer show up in element completions.

dotnet/aspnetcore#9133
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Oct 18, 2019
Remove directive attribute completions from element completion list.
a7405a9 
- This removes the excess amount of directive attribute completions that show up when completing a component.
- Added a test to verify directive attributes no longer show up in element completions.

dotnet/aspnetcore#9133
@NTaylorMullen NTaylorMullen added Done This issue has been fixed and removed Working labels Oct 18, 2019
@NTaylorMullen NTaylorMullen mentioned this issue Oct 21, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel
Projects
None yet
Milestone
3.1.0-preview2
Development

No branches or pull requests
5 participants
@pranavkm @rynowak @danroth27 @NTaylorMullen @mkArtakMSFT