Skip to content

Update default Razor versions in VS to be 3.0 #13291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NTaylorMullen opened this issue Aug 20, 2019 · 1 comment
Closed

Update default Razor versions in VS to be 3.0 #13291

NTaylorMullen opened this issue Aug 20, 2019 · 1 comment
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel
Milestone
3.1.0-preview1

Comments

@NTaylorMullen
Copy link

NTaylorMullen commented Aug 20, 2019 •
edited
Loading

Today when you open a project we assume the Razor version by the suffix of the Razor file (.cshtml -> 2.2 MVC, .razor -> 3.0 MVC). However, when you open a .cshtml file we should start assuming 3.0 MVC (because that's what is released).

I've already done the code bits of this work here: https://github.com/aspnet/AspNetCore-Tooling/tree/nimullen/13291

Just need to verify it actually works in VS and in tests 😄
@NTaylorMullen NTaylorMullen added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates cost: XS area-blazor Includes: Blazor, Razor Components labels Aug 20, 2019
@NTaylorMullen NTaylorMullen added this to the 3.1.0-preview1 milestone Aug 20, 2019
@NTaylorMullen NTaylorMullen self-assigned this Aug 20, 2019
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Aug 20, 2019
Default to MVC 3.0 when we can't detect the Razor configuration.
7f9f714 
- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration.
- Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two).

dotnet/aspnetcore#13291
@mkArtakMSFT mkArtakMSFT added Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel PRI: 1 - Required labels Sep 9, 2019
@NTaylorMullen
Copy link
Author

NTaylorMullen commented Sep 23, 2019 •
edited
Loading

This also includes setting the default to 3.0 for the Razor language server: #14305

@NTaylorMullen NTaylorMullen mentioned this issue Sep 23, 2019
Closed
@danroth27 danroth27 mentioned this issue Sep 24, 2019
Closed
10 tasks
ajaybhargavb pushed a commit to dotnet/razor that referenced this issue Sep 24, 2019
@ajaybhargavb
Default to MVC 3.0 when we can't detect the Razor configuration.
9e3a93b 
- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration.
- Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two).

dotnet/aspnetcore#13291
@ajaybhargavb ajaybhargavb mentioned this issue Sep 24, 2019
Merged
@danroth27 danroth27 added bug This issue describes a behavior which is not expected - a bug. and removed enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Sep 25, 2019
ajaybhargavb added a commit to dotnet/razor that referenced this issue Oct 1, 2019
@ajaybhargavb
Default to MVC 3.0 when we can't detect the Razor configuration (#1167)
c439c5d 
* Default to MVC 3.0 when we can't detect the Razor configuration.

- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration.
- Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two).

dotnet/aspnetcore#13291

* Set RazorLanguageServer default RazorVersion to 3.0
@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed Working labels Oct 1, 2019
ajaybhargavb added a commit to dotnet/razor that referenced this issue Oct 1, 2019
@ajaybhargavb
Default to MVC 3.0 when we can't detect the Razor configuration (#1167)
95b412e 
* Default to MVC 3.0 when we can't detect the Razor configuration.

- Added a `Latest` configuration so we no longer need to look through every file to update the "latest" fallback configuration.
- Added understanding for MVC2.2, we default to the 2.1 configuration (there were no Razor changes between the two).

dotnet/aspnetcore#13291

* Set RazorLanguageServer default RazorVersion to 3.0
@ajaybhargavb ajaybhargavb mentioned this issue Oct 1, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed Tooling This issue has a tooling impact, which means the execution and release should be in sync with VS rel
Projects
None yet
Milestone
3.1.0-preview1
Development

No branches or pull requests
4 participants
@ajaybhargavb @danroth27 @NTaylorMullen @mkArtakMSFT