Rubocop - Style/MethodDefParentheses

Author: JaniJegoroff

lib/appium_lib/android/client_xpath.rb

@@ -2,7 +2,7 @@
 
 module Appium
   module Android
-    def _nodeset_to_uiselector opts = {}
+    def _nodeset_to_uiselector(opts = {})
       results = ''
 
       nodes = opts[:nodes]
@@ -17,7 +17,7 @@ def _nodeset_to_uiselector opts = {}
       results.strip
     end
 
-    def _client_xpath opts = {}
+    def _client_xpath(opts = {})
       root_node = Nokogiri::XML(get_source).children.first
 
       instance = Hash.new -1
@@ -33,11 +33,11 @@ def _client_xpath opts = {}
       _nodeset_to_uiselector nodes: nodes, first: first
     end
 
-    def client_xpath xpath
+    def client_xpath(xpath)
       find_element :uiautomator, _client_xpath(xpath: xpath, first: true)
     end
 
-    def client_xpaths xpath
+    def client_xpaths(xpath)
       find_elements :uiautomator, _client_xpath(xpath: xpath, first: false)
     end
   end

lib/appium_lib/android/element/alert.rb

@@ -3,7 +3,7 @@ module Android
     # Click the first alert button that contains value or by index.
     # @param value [Integer, String] either an integer index of the button or the button's name
     # @return [void]
-    def alert_click value
+    def alert_click(value)
       button(value).click
     end
 

lib/appium_lib/android/element/button.rb

@@ -7,7 +7,7 @@ module Android
     private
 
     # @private
-    def _button_visible_selectors opts = {}
+    def _button_visible_selectors(opts = {})
       button_index       = opts.fetch :button_index, false
       image_button_index = opts.fetch :image_button_index, false
 
@@ -21,14 +21,14 @@ def _button_visible_selectors opts = {}
     end
 
     # @private
-    def _button_exact_string value
+    def _button_exact_string(value)
       button       = string_visible_exact Button, value
       image_button = string_visible_exact ImageButton, value
       button + image_button
     end
 
     # @private
-    def _button_contains_string value
+    def _button_contains_string(value)
       button       = string_visible_contains Button, value
       image_button = string_visible_contains ImageButton, value
       button + image_button
@@ -40,7 +40,7 @@ def _button_contains_string value
     # @param value [String, Integer] the value to exactly match.
     # If int then the button at that index is returned.
     # @return [Button]
-    def button value
+    def button(value)
       # Don't use ele_index because that only works on one element type.
       # Android needs to combine button and image button to match iOS.
       if value.is_a? Numeric
@@ -57,7 +57,7 @@ def button value
     # If value is omitted, all buttons are returned.
     # @param value [String] the value to search for
     # @return [Array<Button>]
-    def buttons value = false
+    def buttons(value = false)
       return find_elements :uiautomator, _button_visible_selectors unless value
       find_elements :uiautomator, _button_contains_string(value)
     end
@@ -86,14 +86,14 @@ def last_button
     # Find the first button that exactly matches value.
     # @param value [String] the value to match exactly
     # @return [Button]
-    def button_exact value
+    def button_exact(value)
       find_element :uiautomator, _button_exact_string(value)
     end
 
     # Find all buttons that exactly match value.
     # @param value [String] the value to match exactly
     # @return [Array<Button>]
-    def buttons_exact value
+    def buttons_exact(value)
       find_elements :uiautomator, _button_exact_string(value)
     end
   end # module Android

lib/appium_lib/android/element/generic.rb

@@ -4,40 +4,40 @@ module Android
     # Find the first element containing value
     # @param value [String] the value to search for
     # @return [Element]
-    def find value
+    def find(value)
       complex_find_contains '*', value
     end
 
     # Find all elements containing value
     # @param value [String] the value to search for
     # @return [Array<Element>]
-    def finds value
+    def finds(value)
       complex_finds_contains '*', value
     end
 
     # Find the first element exactly matching value
     # @param value [String] the value to search for
     # @return [Element]
-    def find_exact value
+    def find_exact(value)
       complex_find_exact '*', value
     end
 
     # Find all elements exactly matching value
     # @param value [String] the value to search for
     # @return [Array<Element>]
-    def finds_exact value
+    def finds_exact(value)
       complex_finds_exact '*', value
     end
 
     # @private
-     def scroll_uiselector content
+     def scroll_uiselector(content)
        "new UiScrollable(new UiSelector().scrollable(true).instance(0)).scrollIntoView(#{content}.instance(0));"
      end
 
     # Scroll to the first element containing target text or description.
     # @param text [String] the text to search for in the text value and content description
     # @return [Element] the element scrolled to
-    def scroll_to text
+    def scroll_to(text)
       text = %Q("#{text}")
 
       args = scroll_uiselector("new UiSelector().textContains(#{text})") +
@@ -49,7 +49,7 @@ def scroll_to text
     # Scroll to the first element with the exact target text or description.
     # @param text [String] the text to search for in the text value and content description
     # @return [Element] the element scrolled to
-    def scroll_to_exact text
+    def scroll_to_exact(text)
       text = %Q("#{text}")
 
       args = scroll_uiselector("new UiSelector().text(#{text})") +

lib/appium_lib/android/element/text.rb

@@ -7,7 +7,7 @@ module Android
     # @param value [String, Integer] the value to find.
     # If int then the TextView at that index is returned.
     # @return [TextView]
-    def text value
+    def text(value)
       return ele_index TextView, value if value.is_a? Numeric
       complex_find_contains TextView, value
     end
@@ -16,7 +16,7 @@ def text value
     # If value is omitted, all texts are returned.
     # @param value [String] the value to search for
     # @return [Array<TextView>]
-    def texts value = false
+    def texts(value = false)
       return tags TextView unless value
       complex_finds_contains TextView, value
     end
@@ -36,14 +36,14 @@ def last_text
     # Find the first TextView that exactly matches value.
     # @param value [String] the value to match exactly
     # @return [TextView]
-    def text_exact value
+    def text_exact(value)
       complex_find_exact TextView, value
     end
 
     # Find all TextViews that exactly match value.
     # @param value [String] the value to match exactly
     # @return [Array<TextView>]
-    def texts_exact value
+    def texts_exact(value)
       complex_finds_exact TextView, value
     end
   end # module Android

lib/appium_lib/android/element/textfield.rb

@@ -6,7 +6,7 @@ module Android
     # @param value [String, Integer] the text to match exactly.
     # If int then the EditText at that index is returned.
     # @return [EditText]
-    def textfield value
+    def textfield(value)
       return ele_index EditText, value if value.is_a? Numeric
       complex_find_contains EditText, value
     end
@@ -15,7 +15,7 @@ def textfield value
     # If value is omitted, all EditTexts are returned.
     # @param value [String] the value to search for
     # @return [Array<EditText>]
-    def textfields value = false
+    def textfields(value = false)
       return tags EditText unless value
       complex_finds_contains EditText, value
     end
@@ -35,14 +35,14 @@ def last_textfield
     # Find the first EditText that exactly matches value.
     # @param value [String] the value to match exactly
     # @return [EditText]
-    def textfield_exact value
+    def textfield_exact(value)
       complex_find_exact EditText, value
     end
 
     # Find all EditTexts that exactly match value.
     # @param value [String] the value to match exactly
     # @return [Array<EditText>]
-    def textfields_exact value
+    def textfields_exact(value)
       complex_finds_exact EditText, value
     end
   end # module Android