refactor: replace core directory to core library (#718)

* replace core directory to core library

* add recording related command tests

* remove source_window

* remove current app

* remove unused rubocop rule

* remove some test code

* remove unnecessary tests since they'be already tested in core

* remove the core library related tests

Author: KazuCocoa

android_tests/lib/android/specs/android/helper.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Metrics/LineLength
-
 # rake android[android/helper]
 describe 'android/helper' do
   t 'tags' do
@@ -78,34 +76,4 @@ def id_value
   t 'ids' do
     wait { ids('android:id/text1').length.must_equal 12 }
   end
-
-  t '_parse_current_app_line' do
-    # test values from appium's test/unit/adb-specs.js
-    expected = [
-      # api 16 line
-      ['mFocusedApp=AppWindowToken{417ee228 token=Token{41602f78 ActivityRecord{41798a08 io.appium.android.apis/.ApiDemos}}}',
-       'io.appium.android.apis',
-       '.ApiDemos'],
-      # api 18 line
-      ['mFocusedApp=AppWindowToken{41744660 token=Token{41ac7198 ActivityRecord{41af55c8 u0 io.appium.android.apis/.ApiDemos}}}',
-       'io.appium.android.apis',
-       '.ApiDemos'],
-      # api 19
-      ['mFocusedApp=AppWindowToken{b40af858 token=Token{b3e2ce38 ActivityRecord{b3eb47d8 u0 io.appium.android.apis/.ApiDemos t6}}}',
-       'io.appium.android.apis',
-       '.ApiDemos'],
-      # api 16 selendroid
-      ['mFocusedApp=AppWindowToken{4157a2c8 token=Token{41582628 ActivityRecord{415821f0 com.android.launcher/com.android.launcher2.Launcher}}}',
-       'com.android.launcher',
-       'com.android.launcher2.Launcher']
-    ]
-
-    expected.each do |line, package, activity|
-      parsed = _parse_current_app_line(line)
-      raise "failed to parse #{line}" if parsed.nil?
-      parsed.package.must_equal package
-      parsed.activity.must_equal activity
-      parsed.am_start.must_equal package + '/' + activity
-    end
-  end
 end

android_tests/lib/android/specs/common/command.rb

@@ -1,16 +1,5 @@
 # rake android[common/device]
 describe 'common/device' do
-  # Not yet implemented
-  t 'shake' do
-    # TODO: write test
-  end
-
-  t 'remove & install' do
-    # TODO: write test
-    # remove 'com.example.android.apis'
-    # install ENV['APP_PATH']
-  end
-
   t 'get_performance_data_types' do
     expected = %w(batteryinfo cpuinfo memoryinfo networkinfo)
     get_performance_data_types.sort.must_equal expected
@@ -19,26 +8,6 @@
                          data_type: 'cpuinfo').must_equal [%w(user kernel), %w(0 0)]
   end
 
-  t 'device_time' do
-    Date.parse(device_time)
-  end
-
-  t 'get_system_bars' do
-    get_system_bars
-  end
-
-  t 'get_display_density' do
-    (get_display_density > 0).must_equal true
-  end
-
-  t 'system_bars' do
-    is_keyboard_shown.must_equal false
-  end
-
-  t 'background_app' do
-    wait { background_app 5 }
-  end
-
   t 'start_activity' do
     wait { current_activity.must_equal '.ApiDemos' }
     start_activity app_package: 'io.appium.android.apis',
@@ -55,31 +24,6 @@
     wait { current_package.must_equal 'io.appium.android.apis' }
   end
 
-  t 'installed' do
-    wait { app_installed?('fake_app').must_equal false }
-  end
-
-  t 'reset' do
-    reset
-    wait { text(1).text.must_equal 'API Demos' }
-  end
-
-  t 'device_locked? and unlock' do
-    lock 5
-    wait { device_locked?.must_equal true }
-    unlock
-    wait { device_locked?.must_equal false }
-  end
-
-  t 'close & launch' do
-    close_app
-    launch_app
-  end
-
-  t 'current_activity' do
-    wait { current_activity.must_equal '.ApiDemos' }
-  end
-
   t 'app_strings' do
     wait_true { app_strings.key? 'activity_save_restore' }
   end
@@ -97,69 +41,4 @@ def must_return_element(element)
     # http://developer.android.com/reference/android/view/KeyEvent.html
     long_press_keycode 176
   end
-
-  t 'open_notifications' do
-    # test & comments from https://github.com/appium/appium/blob/master/test/functional/android/apidemos/notifications-specs.js#L19
-    # get to the notification page
-    wait { scroll_to('App').click }
-    wait { scroll_to('Notification').click }
-    wait { scroll_to('Status Bar').click }
-    # create a notification
-    wait { button(':-|').click }
-    open_notifications
-    # shouldn't see the elements behind shade
-    wait_true { !exists { find(':-|') } }
-    # should see the notification
-    wait_true { text_exact 'Mood ring' }
-    # return to app
-    back
-    # should be able to see elements from app
-    wait_true { button(':-|') }
-
-    # go back, waiting for each page to load.
-    # if we go back using 3.times { back }
-    # then android will flake out and discard some back events
-    back
-    wait { text('Status Bar') }
-    back
-    wait { text('Notification') }
-    back
-    wait { text('App') }
-  end
-
-  t 'push and pull file' do
-    file = 'A Fine Day'
-    path = '/data/local/tmp/remote.txt'
-    wait do
-      push_file path, file
-      read_file = pull_file path
-      read_file.must_equal file
-    end
-  end
-
-  t 'pull_folder' do
-    data = pull_folder '/data/local/tmp'
-    data.length.must_be :>, 100
-  end
-
-  t 'ime_available_engines' do
-    ime_latin = 'com.google.android.inputmethod.latin/com.android.inputmethod.latin.LatinIME'
-
-    wait { find('app').click }
-    wait { find('Search').click }
-    wait { find('Invoke Search').click }
-
-    imes = ime_available_engines
-    imes.include?(ime_latin).must_equal true
-
-    wait { ime_activate(ime_latin) }
-    ime_active_engine.must_equal ime_latin
-    ime_activated.must_equal true
-
-    wait { ime_deactivate }
-    ime_active_engine.wont_equal ime_latin
-
-    wait { ime_activate(ime_latin) }
-    ime_active_engine.must_equal ime_latin
-  end
 end

android_tests/lib/android/specs/common/device.rb

@@ -41,20 +41,4 @@ def undo_setcontext_nav
 
     undo_setcontext_nav
   end
-
-  t 'within_context' do
-    $driver.within_context 'NATIVE_APP' do
-      wait { current_context.must_equal 'NATIVE_APP' }
-    end
-  end
-
-  t 'switch_to_default_context' do
-    wait do
-      switch_to_default_context
-      current_context.must_equal 'NATIVE_APP'
-    end
-
-    wait { set_context 'NATIVE_APP' }
-    wait { current_context.must_equal 'NATIVE_APP' }
-  end
 end

android_tests/lib/android/specs/common/web_context.rb

@@ -34,30 +34,6 @@ def sauce?
       apk_name.must_equal 'api.apk'
     end
 
-    t 'verify Appium::Core::Base::Capabilities.create_capabilities' do
-      expected_app = File.absolute_path('../test_apps/api.apk')
-      caps = ::Appium::Core::Base::Capabilities.create_capabilities(platformName: 'Android',
-                                                                    app:          expected_app,
-                                                                    appPackage:   'io.appium.android.apis',
-                                                                    appActivity:  'io.appium.android.apis.ApiDemos',
-                                                                    deviceName:   'Nexus 7',
-                                                                    some_capability: 'some_capability')
-      caps_with_json = JSON.parse(caps.to_json)
-      caps_with_json['platformName'].must_equal 'Android'
-      caps_with_json['app'].must_equal expected_app
-      caps_with_json['appPackage'].must_equal 'io.appium.android.apis'
-      caps_with_json['appActivity'].must_equal 'io.appium.android.apis.ApiDemos'
-      caps_with_json['deviceName'].must_equal 'Nexus 7'
-      caps_with_json['someCapability'].must_equal 'some_capability'
-
-      caps[:platformName].must_equal 'Android'
-      caps[:app].must_equal expected_app
-      caps[:appPackage].must_equal 'io.appium.android.apis'
-      caps[:appActivity].must_equal 'io.appium.android.apis.ApiDemos'
-      caps[:deviceName].must_equal 'Nexus 7'
-      caps[:some_capability].must_equal 'some_capability'
-    end
-
     t 'verify all attributes' do
       actual                = driver_attributes
       caps_app_for_teardown = actual[:caps][:app]
@@ -109,11 +85,6 @@ def sauce?
         raise message
       end
     end
-
-    t 'default timeout for http client' do
-      http_client.open_timeout.must_equal 999_999
-      http_client.read_timeout.must_equal 999_999
-    end
   end
 
   describe 'Appium::Driver' do
@@ -190,28 +161,6 @@ def validate_path(path)
       client_version.must_equal expected
     end
 
-    # Skip:
-    #   ios_capabilities # save for iOS tests
-    #   absolute_app_path # tested already by starting the driver for this test
-    #   server_url # sauce labs only
-
-    t 'set_immediate_value' do
-      back # To go to top
-
-      wait { find('app').click }
-      wait { find('activity').click }
-      wait { find('custom title').click }
-
-      message = 'hello'
-
-      wait do
-        elem = textfield(1)
-        elem.clear
-        set_immediate_value(elem, message)
-        elem.text.must_equal message
-      end
-    end
-
     t 'restart' do
       set_wait 1 # ensure wait is 1 before we restart.
       restart

android_tests/lib/android/specs/driver.rb

@@ -13,9 +13,7 @@ Gem::Specification.new do |s|
   s.homepage      = 'https://github.com/appium/ruby_lib' # published as appium_lib
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency 'selenium-webdriver', '~> 3.4', '>= 3.4.1'
-  s.add_runtime_dependency 'awesome_print', '~> 1.8'
-  s.add_runtime_dependency 'json', '>= 1.8'
+  s.add_runtime_dependency 'appium_lib_core', '~> 0.1'
   s.add_runtime_dependency 'tomlrb', '~> 1.1'
   s.add_runtime_dependency 'nokogiri', '~> 1.6', '>= 1.6.6'