Fix CS

Author: meyerbaptiste

.php_cs.dist

@@ -43,7 +43,6 @@ return PhpCsFixer\Config::create()
             'throw',
             'use',
         ],
-        'no_unreachable_default_argument_value' => true,
         'no_useless_else' => true,
         'no_useless_return' => true,
         'ordered_imports' => true,

src/Util/AnnotationFilterExtractorTrait.php

@@ -36,7 +36,7 @@ trait AnnotationFilterExtractorTrait
     private function getFilterAnnotations(array $miscAnnotations): \Iterator
     {
         foreach ($miscAnnotations as $miscAnnotation) {
-            if (get_class($miscAnnotation) === ApiFilter::class) {
+            if (ApiFilter::class === get_class($miscAnnotation)) {
                 yield $miscAnnotation;
             }
         }

tests/Bridge/Symfony/Bundle/DependencyInjection/Compiler/AnnotationFilterPassTest.php

@@ -21,6 +21,7 @@
 use ApiPlatform\Core\Bridge\Symfony\Bundle\DependencyInjection\Compiler\AnnotationFilterPass;
 use ApiPlatform\Core\Serializer\Filter\GroupFilter;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Doctrine\Orm\Filter\AnotherDummyFilter;
+use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
 use Doctrine\Common\Annotations\Reader;
 use Prophecy\Argument;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
@@ -47,15 +48,15 @@ public function testProcess()
         $reader = $this->prophesize(Reader::class);
 
         $reader->getPropertyAnnotations(Argument::type(\ReflectionProperty::class))->will(function ($args) {
-            if ($args[0]->class === 'ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy' && $args[0]->name === 'dummyDate') {
+            if (Dummy::class === $args[0]->class && 'dummyDate' === $args[0]->name) {
                 return [new ApiFilter(['value' => DateFilter::class]), new ApiProperty()];
             }
 
             return [];
         });
 
         $reader->getClassAnnotations(Argument::type(\ReflectionClass::class))->will(function ($args) {
-            if ($args[0]->name === 'ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy') {
+            if (Dummy::class === $args[0]->name) {
                 return [new ApiFilter(['value' => SearchFilter::class, 'strategy' => 'exact', 'properties' => ['description', 'relatedDummy.name', 'name']]), new ApiResource(), new ApiFilter(['value' => GroupFilter::class, 'arguments' => ['parameterName' => 'foobar']])];
             }
 
@@ -118,7 +119,7 @@ public function testProcessWrongFilter()
         });
 
         $reader->getClassAnnotations(Argument::type(\ReflectionClass::class))->will(function ($args) {
-            if ($args[0]->name === 'ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy') {
+            if (Dummy::class === $args[0]->name) {
                 return [new ApiFilter(['value' => AnotherDummyFilter::class])];
             }
 
@@ -149,7 +150,7 @@ public function testProcessExistingFilter()
         });
 
         $reader->getClassAnnotations(Argument::type(\ReflectionClass::class))->will(function ($args) {
-            if ($args[0]->name === 'ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy') {
+            if (Dummy::class === $args[0]->name) {
                 return [new ApiFilter(['value' => SearchFilter::class])];
             }