[MSHADE-467] Improved concurrency problem fix

Code review: Synchronising on session.getProjectBuildingRequest() is
less invasive than a global reentrant lock and therefore preferable to
the reviewer.

Co-authored-by: Romain Manni-Bucau <rmannibucau@gmail.com>

Author: kriegaex

src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java

@@ -35,8 +35,6 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
-import java.util.concurrent.locks.Lock;
-import java.util.concurrent.locks.ReentrantLock;
 
 import org.apache.maven.RepositoryUtils;
 import org.apache.maven.artifact.Artifact;
@@ -1050,8 +1048,6 @@ private void createDependencyReducedPom(Set<String> artifactsToRemove)
         rewriteDependencyReducedPomIfWeHaveReduction(dependencies, modified, transitiveDeps, model);
     }
 
-    private static final Lock LOCK = new ReentrantLock();
-
     private void rewriteDependencyReducedPomIfWeHaveReduction(
             List<Dependency> dependencies, boolean modified, List<Dependency> transitiveDeps, Model model)
             throws IOException, ProjectBuildingException, DependencyGraphBuilderException {
@@ -1116,9 +1112,7 @@ private void rewriteDependencyReducedPomIfWeHaveReduction(
                     w.close();
                 }
 
-                // Lock critical section to fix MSHADE-467
-                try {
-                    LOCK.lock();
+                synchronized (session.getProjectBuildingRequest()) { // Lock critical section to fix MSHADE-467
                     ProjectBuildingRequest projectBuildingRequest =
                             new DefaultProjectBuildingRequest(session.getProjectBuildingRequest());
                     projectBuildingRequest.setLocalRepository(session.getLocalRepository());
@@ -1128,8 +1122,6 @@ private void rewriteDependencyReducedPomIfWeHaveReduction(
 
                     getLog().debug("updateExcludesInDeps()");
                     modified = updateExcludesInDeps(result.getProject(), dependencies, transitiveDeps);
-                } finally {
-                    LOCK.unlock();
                 }
             }