Restoration of Extension Methods

[jonsuda]

My team has an existing project that uses a legacy version of UnitsNet (currently v3.102.0). We would like to upgrade to the latest version, but our code base relies heavily on the extension methods that were removed as part of the effort to cut down the size of the package (#372).

We understand the desire to keep the package small, which is why we’re not suggesting bringing the extension methods back into the main UnitsNet package. What we propose is creating another package, UnitsNet.Extensions (or something like that) specifically for these optional “convenience” pieces of functionality. (Bringing the extension methods back would be the first step; additional stuff might be added on a need-to-do basis in the future.)

As we need this functionality and will have to expend the effort to bring it back either way, we’d be more than happy to give back to the community by making our contribution open source (as opposed to simply doing it as our own project in our own private repository). We think it makes sense, however, for it to exist together with the rest of UnitsNet. In other words, we would like you to own it (even though we’re definitely open to making further contributions to it in the future).

Would you, in principle, be interested in such a contribution?

Here’s a summary of what we’re proposing:

• We add another class library project, UnitsNet.Extensions (or similar), to the solution
• We restore the code generator for the extension methods (convert it from PowerShell to C#)
• We modify the build process to build and deploy an additional Nuget package, UnitsNet.Extensions; this package will have a dependency on the core UnitsNet package
• Anyone interested in this auxiliary, “convenience” functionality can use this package, but it doesn’t affect the size of the core package
• (We’ve already done much of this internally.)

Thank you!

[angularsen]

Hi, yes we could absolutely add the extension methods back, in one of the decisions back then was to add them back when "someone needed it" and then in a separate nuget package. Your proposal looks to me exactly what is needed, you have my blessing ;-) It is awesome you decided to contribute back, much appreciated!

[luli0401]

Based on the discussion above, I've created a PR: 'NumberTo' Extensions Restoration #742.

[jonsuda]

@angularsen , do you think you'll be able to review our PR (#742 ) any time soon? It's currently blocking our intended UnitsNet upgrade. We could of course use our code internally, but we'd prefer to use the actual (UnitsNet.Extensions) Nuget package. We believe it should be simple :-) Thanks!

[angularsen]

@jonsuda Yes, I got around to it just now. Some comments in the PR.

[luli0401]

@angularsen Could you take a look the PR again when you have time? I've updated it based on our discussion. We are currently waiting for this extension to finish our tasks.
Thank you.

[angularsen]

@luli0401 yes, I just posted an update in the PR, let's continue the discussion there, thanks!