Skip to content

Relative tolerance instead of absolute tolerance #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xferit opened this issue Jan 26, 2018 · 2 comments
Closed

Relative tolerance instead of absolute tolerance #391

0xferit opened this issue Jan 26, 2018 · 2 comments

Comments

@0xferit
Copy link
Contributor

0xferit commented Jan 26, 2018

As discussed in #350 we are planning to implement relative tolerance and use a standard relative tolerance value to test units instead of using a different absolute tolerance value for each unit.

Benefits are:

  • Standardized precision
  • Shorter source-code

We can implement it similar to MathNet.Numerics.Precision.Equality

@tmilnthorp
Copy link
Collaborator

I think this can be closed now unless anyone has any objections?

@angularsen
Copy link
Owner

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants