Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Remove usage of private angular core API #402

Closed
ThomasBurleson opened this issue Aug 31, 2017 · 1 comment
Closed

Remove usage of private angular core API #402

ThomasBurleson opened this issue Aug 31, 2017 · 1 comment
Assignees
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease

Comments

@ThomasBurleson
Copy link
Contributor

Current code uses imports and code such as:

import {ɵgetDOM as getDom} from '@angular/platform-browser';

return getDom().getStyle(element, styleName);

This is a private API. Replace this will solution similar to that used in @angular/material.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.10 milestone Aug 31, 2017
@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Aug 31, 2017
@ThomasBurleson ThomasBurleson self-assigned this Aug 31, 2017
@ThomasBurleson ThomasBurleson modified the milestones: v2.0.1-beta.10, v2.0.1-rc.1 Nov 4, 2017
@CaerusKaru CaerusKaru added the has pr A PR has been created to address this issue label Jan 8, 2018
@CaerusKaru CaerusKaru modified the milestones: v5.0.0-rc.1, v2.0.0-beta.13 Jan 8, 2018
ThomasBurleson pushed a commit that referenced this issue Jan 15, 2018
* Remove private API references to getDom()
* Add PLATFORM_ID to all components
* Fix Demo-App runtime - add router to system-config

Closes #553.
Fixes #402, Fixes #547.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
2 participants