This repository was archived by the owner on Jan 6, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 768
feat(core): implement MediaTrigger to allow manual activations #997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
088af1e
to
3636b6c
Compare
ping @CaerusKaru |
CaerusKaru
suggested changes
Jan 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small changes, o/w looks good!
3636b6c
to
eb3a4d4
Compare
CaerusKaru
reviewed
Jan 15, 2019
d41c70e
to
c2da429
Compare
…ions Windows MatchMedia API announces breakpoint activations during viewport resizing. For ome usage scenarios, support for manual activations is needed (without resizing). * immediate rendering of layouts for specific (1..n) breakpoints * for SSR
c2da429
to
4c6660d
Compare
CaerusKaru
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
pr: lgtm
This PR has been approved by the reviewer
pr: merge ready
This PR is ready for the caretaker to presubmit and merge
pr: merge safe
The caretaker can merge this PR without doing a presubmit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows MatchMedia API announces breakpoint activations during viewport resizing.
For some scenarios, developers need support for manual activations (without resizing).
Such features are useful for: