Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix(sass): update stylesheet with correct keys #987

Merged
merged 1 commit into from
Jan 13, 2019
Merged

Conversation

CaerusKaru
Copy link
Member

No description provided.

@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Jan 13, 2019
@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer and removed pr: needs review labels Jan 13, 2019
@CaerusKaru CaerusKaru merged commit 002eb66 into master Jan 13, 2019
@CaerusKaru CaerusKaru deleted the adam/mq branch January 13, 2019 23:07
@fabiocarneiro
Copy link

Nice!

@mackelito
Copy link

When can we expect this to be released? I'm really eager to try out the overlapping keys :)

@CaerusKaru
Copy link
Member Author

It’ll be included in the next beta release, currently tracking for mid-February.

@angular angular deleted a comment from YakirSmartag Mar 14, 2019
@jarekw87
Copy link

@CaerusKaru please fix the mixin:

@mixin layout-bp($bp) {
  @if map-has-key($breakpoints, $bp) {
    $min: map-get(map-get($breakpoints, $bp), begin);
    $max: map-get(map-get($breakpoints, $bp), end);
    @media (min-width: $min) and (max-width: $max) { @content;  background-color: green;}
  }
  @else if map-has-key($overlapping-gt, $bp) {
    $min: map-get($overlapping-gt, $bp); // $breakpoints change to $overlapping-gt
    @media (min-width: $min) { @content; background-color: pink; }
  }
  @else if map-has-key($overlapping-lt, $bp) {
    $max: map-get($overlapping-lt, $bp); //$breakpoints change to $overlapping-lt
    @media (max-width: $max) { @content; background-color: blue;}
  }
}

When can we expect this to be released? :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants