Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix(extended): add demo to show fxHide with used with custom breakpoint #969

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

ThomasBurleson
Copy link
Contributor

Add demo showing custom breakpoint working with fxHide.yba-min-height

Closes #961.

@ThomasBurleson ThomasBurleson force-pushed the thomas/fix-issue-961 branch 4 times, most recently from 153ad7a to 8f138eb Compare January 10, 2019 16:35
@CaerusKaru
Copy link
Member

@ThomasBurleson Please rebase, and remove commit for media$ deprecation.

@ThomasBurleson
Copy link
Contributor Author

@CaerusKaru - final review requested.

@ThomasBurleson ThomasBurleson force-pushed the thomas/fix-issue-961 branch 2 times, most recently from e0b3abf to 86ef7ff Compare January 13, 2019 19:16
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru added pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit and removed pr: needs review labels Jan 13, 2019
@CaerusKaru CaerusKaru self-assigned this Jan 13, 2019
@ThomasBurleson ThomasBurleson force-pushed the thomas/fix-issue-961 branch 3 times, most recently from 049610c to baf8f8e Compare January 13, 2019 19:52
Add demo showing custom breakpoint working with `fxHide.yba-min-height`
Refs #961.
@ThomasBurleson ThomasBurleson merged commit f4eb901 into master Jan 13, 2019
@CaerusKaru CaerusKaru deleted the thomas/fix-issue-961 branch January 13, 2019 19:59
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge pr: merge safe The caretaker can merge this PR without doing a presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fxHide with custom breakpoint directive not working in AOT
3 participants