Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

layout not working in Safari v8 #259

Closed
karlhaas opened this issue Apr 15, 2017 · 8 comments
Closed

layout not working in Safari v8 #259

karlhaas opened this issue Apr 15, 2017 · 8 comments

Comments

@karlhaas
Copy link
Contributor

According to http://caniuse.com/#feat=flexbox there are many browser versions which just support flexbox with a prefix. Currently we can see that the layout is not working in Safari 8. Is this a bug or does the project not support prefixes? 97% of all browsers would be ok for our project, 86% not really.

@ThomasBurleson
Copy link
Contributor

Evergreen browsers do not include S8. See

http://caniuse.com/#feat=flexbox

@karlhaas
Copy link
Contributor Author

@ThomasBurleson why does the project not support browsers which need a webkit prefix?

@karlhaas
Copy link
Contributor Author

Maybe just https://github.com/angular/flex-layout/blob/master/src/lib/utils/auto-prefixer.ts#L18 causes the issue.
I will provide a PR (master...karlhaas:fix-display-prefixes) if it works on Safari 8.

@ThomasBurleson
Copy link
Contributor

Thx @karlhaas. Is this legal:

switch (key) {
      case 'display':
        if (value === 'flex') {
          target['display'] = [
            '-webkit-box',
            '-moz-box',
            '-ms-flexbox',
            '-webkit-flex',
            'flex'
          ];
        } else {
          target['display'] = value;
        }
        break;

@karlhaas
Copy link
Contributor Author

@ThomasBurleson I found this solution here

@karlhaas
Copy link
Contributor Author

karlhaas commented May 4, 2017

@ThomasBurleson it works in iOS8 now. PR: #276

@karlhaas
Copy link
Contributor Author

karlhaas commented Jun 6, 2017

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants