Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix(ObservableMedia): provide consistent reporting of active breakpoint #186

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

ThomasBurleson
Copy link
Contributor

@ThomasBurleson ThomasBurleson commented Feb 16, 2017

ObservableMedia reports of the active breakpoint are not consistent:

  • during page startup - active breakpoint as "gt-sm" instead of "md", "lg", or "xl".
  • during manual resize - active breakpoint as "xs", "sm", "md", "lg", or "xl".

ObservableMedia should not (by default) report gt-<xxx> activations.

fixes #185.

@ThomasBurleson ThomasBurleson force-pushed the fix/issue_185 branch 4 times, most recently from 7228054 to efc611e Compare February 19, 2017 18:03
@ThomasBurleson ThomasBurleson self-assigned this Feb 19, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-rc.1 milestone Feb 19, 2017
@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit pr: merge #2 labels Feb 19, 2017
@ThomasBurleson ThomasBurleson force-pushed the fix/issue_185 branch 2 times, most recently from 51a97d7 to ed48ab8 Compare February 21, 2017 20:30
**ObservableMedia** event reports regarding current  active breakpoint are not consistent:

*  during page startup - active breakpoint may show as "gt-sm"  instead of "md", "lg", or "xl".
*  during manual resize - active breakpoint will as "xs", "sm", "md", "lg", or "xl".

fixes #185.
@mmalerba mmalerba merged commit aa0dab4 into master Feb 21, 2017
@ThomasBurleson ThomasBurleson deleted the fix/issue_185 branch March 4, 2017 22:54
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
…nt (angular#186)

**ObservableMedia** event reports regarding current  active breakpoint are not consistent:

*  during page startup - active breakpoint may show as "gt-sm"  instead of "md", "lg", or "xl".
*  during manual resize - active breakpoint will as "xs", "sm", "md", "lg", or "xl".

fixes angular#185.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: needs presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableMedia service events are not consistent
3 participants