Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fix(build): add observable-media-service to index.ts #139

Merged
merged 1 commit into from
Feb 2, 2017

Conversation

karlhaas
Copy link
Contributor

@karlhaas karlhaas commented Jan 28, 2017

After upgrade to beta 4, I can't import ObservableMediaService from the barrel.

fixes #144.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Jan 28, 2017
@karlhaas
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Jan 28, 2017
@ThomasBurleson
Copy link
Contributor

@karlhaas - good catch.

If needed before Beta5, you can alway use the full path reference to ObservableMediaService.

@ThomasBurleson ThomasBurleson added pr: needs presubmit pr: lgtm This PR has been approved by the reviewer labels Jan 28, 2017
@ThomasBurleson ThomasBurleson changed the title add observable-media-service to index.ts fix(build): add observable-media-service to index.ts Jan 30, 2017
@ThomasBurleson ThomasBurleson removed pr: lgtm This PR has been approved by the reviewer pr: needs presubmit labels Jan 30, 2017
@ThomasBurleson
Copy link
Contributor

@karlhaas - please squash and update the commit with title:

fix(build): add observable-media-service to exported barrel

@karlhaas
Copy link
Contributor Author

@ThomasBurleson done

@ThomasBurleson
Copy link
Contributor

@karlhaas - We love community contributions. Thx again.

@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit and removed pr: needs squash labels Jan 30, 2017
@kara kara added pr: merge ready This PR is ready for the caretaker to presubmit and merge and removed pr: needs presubmit labels Feb 2, 2017
@kara kara merged commit b7dffaa into angular:master Feb 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for the caretaker to presubmit and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(build): ObservableMediaService is not available in the export barrel
4 participants