Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Commit 07c0d0b

Browse files
fix(FlexLayoutModule): remove console.warn() calls that conflict with ngc+aot
* 'forRoot()' fn is never evaluated in AoT, ngc only analyzes the content of the fn to get the module and ngc does not know what to do with the first statetement (console.warn) * clarify changes to FlexLayoutModule.forRoot() Refs http://github.com/angular/angular#14410 Fixes #174, Fixes #175, Fixes #176, Fixes #178.
1 parent ce0009c commit 07c0d0b

File tree

3 files changed

+13
-15
lines changed

3 files changed

+13
-15
lines changed

CHANGELOG.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
### BREAKING CHANGES
2626

2727
* ObservableMedia: Deprecated use of `ObservableMediaService` opaque token. Developers now simply use the ObservableMedia class to inject the service.
28-
* FlexLayoutModule: Previously releases used FlexLayoutModule.forRoot(). This has been deprecated and removed.
28+
* FlexLayoutModule: Previously releases used FlexLayoutModule.forRoot(); This has been deprecated.
2929

3030
*before*
3131

3232
```js
33-
constructor( @Inject(ObserverableMediaService) private media:any ) { ... }
33+
constructor( @Inject(ObserverableMediaService) media:any ) { ... }
3434
```
3535

3636
**after**
@@ -51,7 +51,7 @@ export class MyComponent {
5151
media.asObservable()
5252
.map( (change:MediaChange) => change.mqAlias == 'md' )
5353
.subscribe((change:MediaChange) => {
54-
let state = change ? `'${change.mqAlias}' = (${change.mediaQuery})` : ""
54+
let state = change ? `'${change.mqAlias}' = (${change.mediaQuery})` : "";
5555
console.log( state );
5656
});
5757
}
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { Component } from '@angular/core';
1+
import {Component} from '@angular/core';
22

33
@Component({
4-
selector: 'demos-docs-layout',
5-
template: `
4+
selector: 'demos-docs-layout',
5+
template: `
66
<demo-layout-alignment class="small-demo"> </demo-layout-alignment>
77
<demo-layout-fill class="small-demo"> </demo-layout-fill>
88
<demo-flex-row-fill class="small-demo"> </demo-flex-row-fill>
@@ -12,15 +12,15 @@ import { Component } from '@angular/core';
1212
<demo-flex-offset-values class="small-demo"> </demo-flex-offset-values>
1313
`
1414
})
15-
export class DemosLayoutAPI { }
15+
export class DemosLayoutAPI {
16+
}
1617

1718
import {NgModule} from '@angular/core';
1819
import {CommonModule} from "@angular/common";
1920
import {FormsModule} from "@angular/forms";
2021
import {MaterialModule} from "@angular/material";
2122
import {FlexLayoutModule} from "../../../lib"; // `gulp build:components` to deploy to node_modules manually
2223

23-
2424
import {DemoLayoutAlignment} from "./layoutAlignment.demo";
2525
import {DemoFlexRowFill} from "./flexRowFill.demo";
2626
import {DemoFlexRowFillWrap} from "./flexRowFillWrap.demo";
@@ -29,9 +29,8 @@ import {DemoFlexOffsetValues} from "./flexOffetValues.demo";
2929
import {DemoLayoutFill} from "./layoutFill.demo";
3030
import {DemoFlexAlignSelf} from "./FlexAlignSelf.demo";
3131

32-
3332
@NgModule({
34-
declarations : [
33+
declarations: [
3534
DemosLayoutAPI, // used by the Router with the root app component
3635

3736
DemoFlexRowFill,
@@ -42,12 +41,12 @@ import {DemoFlexAlignSelf} from "./FlexAlignSelf.demo";
4241
DemoLayoutFill,
4342
DemoFlexAlignSelf
4443
],
45-
imports : [
44+
imports: [
4645
CommonModule,
4746
FormsModule,
4847
MaterialModule,
4948
FlexLayoutModule
5049
]
51-
5250
})
53-
export class DemosLayoutAPIModule { }
51+
export class DemosLayoutAPIModule {
52+
}

src/lib/flexbox/_module.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,11 @@ const ALL_DIRECTIVES = [
5757
declarations: ALL_DIRECTIVES,
5858
imports: [MediaQueriesModule],
5959
exports: [MediaQueriesModule, ...ALL_DIRECTIVES],
60-
providers: [ MediaMonitor ]
60+
providers: [MediaMonitor]
6161
})
6262
export class FlexLayoutModule {
6363
/** @deprecated */
6464
static forRoot(): ModuleWithProviders {
65-
console.warn('FlexLayoutModule.forRoot() has been deprecated and is no longer needed.');
6665
return {
6766
ngModule: FlexLayoutModule
6867
};

0 commit comments

Comments
 (0)