Skip to content

bug(checkbox): aria-label and aria-labelledby result in duplicate attributes and verbose screen reader experience #19478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mfairchild365 opened this issue May 28, 2020 · 4 comments
Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@mfairchild365
Copy link

Reproduction

  1. Use NVDA 2020 and Chrome 81
  2. Navigate to https://angular-kjejjn-2lxw6j.stackblitz.io
  3. Tab to the second example "two labels"
  4. Observe that the output is "clickable Check me! hello Check me! hello check box not checked"
  5. Inspect the rendered DOM and observe that aria-labelledby is on both the <mat-checkbox> and <input type="checkbox>.

Expected Behavior

  • NVDA should only announce the labels once, and should not announce "clickable". For example "Check me! hello check box not checked".
  • This is occurring because of the duplicated attribute on the container. The aria-labelledby attribute should not exist on the containing <mat-checkbox>

Actual Behavior

Very verbose output in NVDA.

Environment

  • Angular: 9.2.4
  • CDK/Material: 9.2.4
  • Browser(s): Chrome 81
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows, with NVDA 2020.1
@mfairchild365 mfairchild365 added the needs triage This issue needs to be triaged by the team label May 28, 2020
@mmalerba mmalerba added Accessibility This issue is related to accessibility (a11y) area: material/checkbox labels May 28, 2020
@devversion
Copy link
Member

Great report. Thanks! Looks like there is a PR for this: #17092. There is also a PR pending for button-toggle: #17086.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr and removed needs triage This issue needs to be triaged by the team labels May 29, 2020
@Ckolhari5353
Copy link

Hi,

I'm facing the same issue, any specific release date for this bug fix?

@crisbeto
Copy link
Member

Should be resolved now by #17092.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: material/checkbox P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants