Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit a5a6554

Browse files
committed
fix(uiSelectSort): fix dependency not found error
Also a bit of tidying
1 parent 4467b82 commit a5a6554

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

src/uiSelectSortDirective.js

+22-22
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
11
// Make multiple matches sortable
22
uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', function($timeout, uiSelectConfig, uiSelectMinErr) {
33
return {
4-
require: '^uiSelect',
4+
require: '^^uiSelect',
55
link: function(scope, element, attrs, $select) {
66
if (scope[attrs.uiSelectSort] === null) {
7-
throw uiSelectMinErr('sort', "Expected a list to sort");
7+
throw uiSelectMinErr('sort', 'Expected a list to sort');
88
}
99

1010
var options = angular.extend({
1111
axis: 'horizontal'
1212
},
1313
scope.$eval(attrs.uiSelectSortOptions));
1414

15-
var axis = options.axis,
16-
draggingClassName = 'dragging',
17-
droppingClassName = 'dropping',
18-
droppingBeforeClassName = 'dropping-before',
19-
droppingAfterClassName = 'dropping-after';
15+
var axis = options.axis;
16+
var draggingClassName = 'dragging';
17+
var droppingClassName = 'dropping';
18+
var droppingBeforeClassName = 'dropping-before';
19+
var droppingAfterClassName = 'dropping-after';
2020

2121
scope.$watch(function(){
2222
return $select.sortable;
23-
}, function(n){
24-
if (n) {
23+
}, function(newValue){
24+
if (newValue) {
2525
element.attr('draggable', true);
2626
} else {
2727
element.removeAttr('draggable');
2828
}
2929
});
3030

31-
element.on('dragstart', function(e) {
31+
element.on('dragstart', function(event) {
3232
element.addClass(draggingClassName);
3333

34-
(e.dataTransfer || e.originalEvent.dataTransfer).setData('text/plain', scope.$index);
34+
(event.dataTransfer || event.originalEvent.dataTransfer).setData('text/plain', scope.$index);
3535
});
3636

3737
element.on('dragend', function() {
@@ -43,10 +43,10 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
4343
this.splice(to, 0, this.splice(from, 1)[0]);
4444
};
4545

46-
var dragOverHandler = function(e) {
47-
e.preventDefault();
46+
var dragOverHandler = function(event) {
47+
event.preventDefault();
4848

49-
var offset = axis === 'vertical' ? e.offsetY || e.layerY || (e.originalEvent ? e.originalEvent.offsetY : 0) : e.offsetX || e.layerX || (e.originalEvent ? e.originalEvent.offsetX : 0);
49+
var offset = axis === 'vertical' ? event.offsetY || event.layerY || (event.originalEvent ? event.originalEvent.offsetY : 0) : event.offsetX || event.layerX || (event.originalEvent ? event.originalEvent.offsetX : 0);
5050

5151
if (offset < (this[axis === 'vertical' ? 'offsetHeight' : 'offsetWidth'] / 2)) {
5252
element.removeClass(droppingAfterClassName);
@@ -60,10 +60,10 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
6060

6161
var dropTimeout;
6262

63-
var dropHandler = function(e) {
64-
e.preventDefault();
63+
var dropHandler = function(event) {
64+
event.preventDefault();
6565

66-
var droppedItemIndex = parseInt((e.dataTransfer || e.originalEvent.dataTransfer).getData('text/plain'), 10);
66+
var droppedItemIndex = parseInt((event.dataTransfer || event.originalEvent.dataTransfer).getData('text/plain'), 10);
6767

6868
// prevent event firing multiple times in firefox
6969
$timeout.cancel(dropTimeout);
@@ -73,9 +73,9 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
7373
};
7474

7575
var _dropHandler = function(droppedItemIndex) {
76-
var theList = scope.$eval(attrs.uiSelectSort),
77-
itemToMove = theList[droppedItemIndex],
78-
newIndex = null;
76+
var theList = scope.$eval(attrs.uiSelectSort);
77+
var itemToMove = theList[droppedItemIndex];
78+
var newIndex = null;
7979

8080
if (element.hasClass(droppingBeforeClassName)) {
8181
if (droppedItemIndex < scope.$index) {
@@ -120,8 +120,8 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
120120
element.on('drop', dropHandler);
121121
});
122122

123-
element.on('dragleave', function(e) {
124-
if (e.target != element) {
123+
element.on('dragleave', function(event) {
124+
if (event.target != element) {
125125
return;
126126
}
127127
element.removeClass(droppingClassName);

0 commit comments

Comments
 (0)