Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit 631ae68

Browse files
committed
rebase
1 parent ce6a554 commit 631ae68

File tree

3 files changed

+23
-11
lines changed

3 files changed

+23
-11
lines changed

src/common.css

+6-2
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,11 @@ body > .ui-select-bootstrap.open {
192192
position: relative;
193193
}
194194

195-
.ui-select-multiple .ui-select-match-item.dropping-before:before {
195+
.ui-select-multiple .ui-select-match-item.dropping .ui-select-match-close {
196+
pointer-events: none;
197+
}
198+
199+
.ui-select-multiple:hover .ui-select-match-item.dropping-before:before {
196200
content: "";
197201
position: absolute;
198202
top: 0;
@@ -202,7 +206,7 @@ body > .ui-select-bootstrap.open {
202206
border-left: 1px solid #428bca;
203207
}
204208

205-
.ui-select-multiple .ui-select-match-item.dropping-after:after {
209+
.ui-select-multiple:hover .ui-select-match-item.dropping-after:after {
206210
content: "";
207211
position: absolute;
208212
top: 0;

src/uiSelectController.js

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ uis.controller('uiSelectCtrl',
4242
ctrl.lockChoiceExpression = undefined; // Initialized inside uiSelectMatch directive link function
4343
ctrl.clickTriggeredSelect = false;
4444
ctrl.$filter = $filter;
45+
ctrl.$element = $element;
4546

4647
// Use $injector to check for $animate and store a reference to it
4748
ctrl.$animate = (function () {

src/uiSelectSortDirective.js

+16-9
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,31 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
3535
});
3636

3737
element.on('dragend', function() {
38-
element.removeClass(draggingClassName);
38+
removeClass(draggingClassName);
3939
});
4040

4141
var move = function(from, to) {
4242
/*jshint validthis: true */
4343
this.splice(to, 0, this.splice(from, 1)[0]);
4444
};
4545

46+
var removeClass = function(className) {
47+
angular.forEach($select.$element.querySelectorAll('.' + className), function(el){
48+
angular.element(el).removeClass(className);
49+
});
50+
};
51+
4652
var dragOverHandler = function(event) {
4753
event.preventDefault();
4854

4955
var offset = axis === 'vertical' ? event.offsetY || event.layerY || (event.originalEvent ? event.originalEvent.offsetY : 0) : event.offsetX || event.layerX || (event.originalEvent ? event.originalEvent.offsetX : 0);
5056

5157
if (offset < (this[axis === 'vertical' ? 'offsetHeight' : 'offsetWidth'] / 2)) {
52-
element.removeClass(droppingAfterClassName);
58+
removeClass(droppingAfterClassName);
5359
element.addClass(droppingBeforeClassName);
5460

5561
} else {
56-
element.removeClass(droppingBeforeClassName);
62+
removeClass(droppingBeforeClassName);
5763
element.addClass(droppingAfterClassName);
5864
}
5965
};
@@ -102,9 +108,9 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
102108
});
103109
});
104110

105-
element.removeClass(droppingClassName);
106-
element.removeClass(droppingBeforeClassName);
107-
element.removeClass(droppingAfterClassName);
111+
removeClass(droppingClassName);
112+
removeClass(droppingBeforeClassName);
113+
removeClass(droppingAfterClassName);
108114

109115
element.off('drop', dropHandler);
110116
};
@@ -124,9 +130,10 @@ uis.directive('uiSelectSort', ['$timeout', 'uiSelectConfig', 'uiSelectMinErr', f
124130
if (event.target != element) {
125131
return;
126132
}
127-
element.removeClass(droppingClassName);
128-
element.removeClass(droppingBeforeClassName);
129-
element.removeClass(droppingAfterClassName);
133+
134+
removeClass(droppingClassName);
135+
removeClass(droppingBeforeClassName);
136+
removeClass(droppingAfterClassName);
130137

131138
element.off('dragover', dragOverHandler);
132139
element.off('drop', dropHandler);

0 commit comments

Comments
 (0)