Merge pull request #1365 from fastmonkeys/fix-angular-element-cache-memory-leak

perf(uiSelect) fix angular.element.cache memory leak

Author: user378230

src/uiSelectChoicesDirective.js

@@ -59,6 +59,10 @@ uis.directive('uiSelectChoices',
 
         $compile(element, transcludeFn)(scope); //Passing current transcludeFn to be able to append elements correctly from uisTranscludeAppend
 
+        scope.$on('$destroy', function() {
+          choices.remove();
+        });
+
         scope.$watch('$select.search', function(newValue) {
           if(newValue && !$select.open && $select.multiple) $select.activate(false, true);
           $select.activeIndex = $select.tagging.isActivated ? -1 : 0;

test/select.spec.js

@@ -348,6 +348,13 @@ describe('ui-select tests', function() {
 
   });
 
+  it('should not leak memory', function() {
+    var cacheLenght = Object.keys(angular.element.cache).length;
+    createUiSelect().remove();
+    scope.$destroy();
+    expect(Object.keys(angular.element.cache).length).toBe(cacheLenght);
+  });
+
   it('should compile child directives', function() {
     var el = createUiSelect();