-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Request: Include src files in Bower repo #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, his pull request allows the overriding of the LESS via variables. Am I missing where the fonts are located in this master repository though? Unless I'm mistaken, I believe the font files are not stored in this repository and are built during the Grunt Fontello process. Ideally, one of the 2 repos (master or bower) would include both the built font files and the src LESS files, so that a user has more solutions to the problem of custom font folder locations. Currently there are 2 solutions:
|
This is something that bootstrap does with bower, correct? There's not a "stripped-down" version of the repo that users can install if they only want compiled files, is there? |
Correct, Bootstrap includes their source CSS. In my experience, it's more common for Bower repos to include source files than not. Angular does not, but Angular is also purely JS. |
+1 |
+1 |
Currently, the Bower repo includes only the distribution files from this repository. This means that a user must always store fonts in the same directory as the CSS, since there is no way to override the font-face URLs.
Adding in the src folder would allow users to import the main LESS file and change the font path as well as any other variables they wish prior to compiling.
I thought that I'd be able to get around this by including this repo directly, instead of the bower distribution repo. Unfortunately fonts aren't built in this repo. I'd need both in order to get the LESS and the fonts together, or I'd need to pull down the full repo and do builds myself. Not an ideal solution.
The text was updated successfully, but these errors were encountered: