Skip to content

Request: Include src files in Bower repo #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuahiggins opened this issue Feb 14, 2015 · 6 comments
Closed

Request: Include src files in Bower repo #2778

joshuahiggins opened this issue Feb 14, 2015 · 6 comments

Comments

@joshuahiggins
Copy link

Currently, the Bower repo includes only the distribution files from this repository. This means that a user must always store fonts in the same directory as the CSS, since there is no way to override the font-face URLs.

Adding in the src folder would allow users to import the main LESS file and change the font path as well as any other variables they wish prior to compiling.

I thought that I'd be able to get around this by including this repo directly, instead of the bower distribution repo. Unfortunately fonts aren't built in this repo. I'd need both in order to get the LESS and the fonts together, or I'd need to pull down the full repo and do builds myself. Not an ideal solution.

@PaulL1
Copy link
Contributor

PaulL1 commented Feb 15, 2015

I seem to recall we did a PR that someone submitted that was to enable fonts to be stored in another directory. I think the trick was to override a variable somewhere. Let me look for it.

#1847 and #1916

@joshuahiggins
Copy link
Author

Yes, his pull request allows the overriding of the LESS via variables. Am I missing where the fonts are located in this master repository though? Unless I'm mistaken, I believe the font files are not stored in this repository and are built during the Grunt Fontello process.

Ideally, one of the 2 repos (master or bower) would include both the built font files and the src LESS files, so that a user has more solutions to the problem of custom font folder locations. Currently there are 2 solutions:

  1. Store font files within same directory, as determined via the distributed UI-Grid build.
  2. Integrate your own Fontello build process for UI-Grid into your project's grunt workflow.

@c0bra
Copy link
Contributor

c0bra commented Feb 16, 2015

This is something that bootstrap does with bower, correct? There's not a "stripped-down" version of the repo that users can install if they only want compiled files, is there?

@joshuahiggins
Copy link
Author

Correct, Bootstrap includes their source CSS. In my experience, it's more common for Bower repos to include source files than not. Angular does not, but Angular is also purely JS.

@c0bra c0bra modified the milestones: 3.1, 3.0 Apr 16, 2015
@c0bra c0bra self-assigned this Apr 16, 2015
@iyeldinov
Copy link

+1

@bierdok
Copy link

bierdok commented May 26, 2015

+1

@c0bra c0bra closed this as completed in b7002ba Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants