Merge pull request #5130 from dennym/correct-seperator-for-ie

fix(exporter): pass column seperator options as param to downloadFile

Author: PaulL1

src/features/exporter/js/exporter.js

@@ -626,7 +626,7 @@
             var exportData = self.getData(grid, rowTypes, colTypes);
             var csvContent = self.formatAsCsv(exportColumnHeaders, exportData, grid.options.exporterCsvColumnSeparator);
 
-            self.downloadFile (grid.options.exporterCsvFilename, csvContent, grid.options.exporterOlderExcelCompatibility);
+            self.downloadFile (grid.options.exporterCsvFilename, csvContent, grid.options.exporterCsvColumnSeparator, grid.options.exporterOlderExcelCompatibility);
           });
         },
 
@@ -909,20 +909,29 @@
          * download as a file
          * @param {boolean} exporterOlderExcelCompatibility whether or not we put a utf-16 BOM on the from (\uFEFF)
          */
-        downloadFile: function (fileName, csvContent, exporterOlderExcelCompatibility) {
+        downloadFile: function (fileName, csvContent, columnSeparator, exporterOlderExcelCompatibility) {
           var D = document;
           var a = D.createElement('a');
           var strMimeType = 'application/octet-stream;charset=utf-8';
           var rawFile;
-          var ieVersion;
+          var ieVersion = this.isIE();
+
+          // IE10+
+          if (navigator.msSaveBlob) {
+            return navigator.msSaveOrOpenBlob(
+              new Blob(
+                [exporterOlderExcelCompatibility ? "\uFEFF" : '', csvContent],
+                { type: strMimeType } ),
+              fileName
+            );
+          }
 
-          ieVersion = this.isIE();
-          if (ieVersion && ieVersion < 10) {
+          if (ieVersion) {
             var frame = D.createElement('iframe');
             document.body.appendChild(frame);
 
-            frame.contentWindow.document.open("text/html", "replace");
-            frame.contentWindow.document.write('sep=,\r\n' + csvContent);
+            frame.contentWindow.document.open('text/html', 'replace');
+            frame.contentWindow.document.write('sep=,' + columnSeparator + '\r\n' + csvContent);
             frame.contentWindow.document.close();
             frame.contentWindow.focus();
             frame.contentWindow.document.execCommand('SaveAs', true, fileName);
@@ -931,16 +940,6 @@
             return true;
           }
 
-          // IE10+
-          if (navigator.msSaveBlob) {
-            return navigator.msSaveOrOpenBlob(
-              new Blob(
-                [exporterOlderExcelCompatibility ? "\uFEFF" : '', csvContent],
-                { type: strMimeType } ),
-              fileName
-            );
-          }
-
           //html5 A[download]
           if ('download' in a) {
             var blob = new Blob(