chore(401_AllFeatures.ngdoc): Fixing console error.

Updating All Features tutorial to follow angular styleguide and prevent console error with

request.

Author: Portugal, Marcelo

misc/tutorial/401_AllFeatures.ngdoc

@@ -13,11 +13,12 @@ All features are enabled to get an idea of performance
   <file name="app.js">
     var app = angular.module('app', ['ngTouch', 'ui.grid', 'ui.grid.cellNav', 'ui.grid.edit', 'ui.grid.resizeColumns', 'ui.grid.pinning', 'ui.grid.selection', 'ui.grid.moveColumns', 'ui.grid.exporter', 'ui.grid.importer', 'ui.grid.grouping']);
 
-    app.controller('MainCtrl',  ['$scope', '$http', '$timeout', '$interval', 'uiGridConstants', 'uiGridGroupingConstants',
+    app.controller('MainCtrl',
      function ($scope, $http, $timeout, $interval, uiGridConstants, uiGridGroupingConstants) {
-       var gridApi;
+       var vm = this,
+         gridApi;
 
-      $scope.gridOptions = {
+      vm.gridOptions = {
         data: 'myData',
         enableCellEditOnFocus: true,
         enableColumnResizing: true,
@@ -60,26 +61,26 @@ All features are enabled to get an idea of performance
         return row.id;
       }
 
-      $scope.toggleFilterRow = function() {
-        $scope.gridOptions.enableFiltering = !$scope.gridOptions.enableFiltering;
+      vm.toggleFilterRow = function() {
+        vm.gridOptions.enableFiltering = !vm.gridOptions.enableFiltering;
         gridApi.core.notifyDataChange(uiGridConstants.dataChange.COLUMN);
       };
 
-      $scope.callsPending = 0;
+      vm.callsPending = 0;
 
       var i = 0;
-      $scope.refreshData = function(){
+      vm.refreshData = function(){
         $scope.myData = [];
 
         var start = new Date();
         var sec = $interval(function () {
-          $scope.callsPending++;
+          vm.callsPending++;
 
           $http.get('/data/500_complex.json')
             .then(function(response) {
               var data = response.data;
 
-              $scope.callsPending--;
+              vm.callsPending--;
 
               data.forEach(function(row){
                 row.id = i;
@@ -88,33 +89,33 @@ All features are enabled to get an idea of performance
                 $scope.myData.push(row);
               });
             })
-            .error(function() {
-              $scope.callsPending--
+            .catch(function() {
+              vm.callsPending--;
             });
         }, 200, 10);
 
 
         var timeout = $timeout(function() {
            $interval.cancel(sec);
-           $scope.left = '';
+           vm.left = '';
         }, 2000);
 
         $scope.$on('$destroy', function(){
           $timeout.cancel(timeout);
           $interval.cancel(sec);
         });
       };
-    }]);
+    });
   </file>
   <file name="index.html">
-    <div ng-controller="MainCtrl">
-      <button id="filterToggle" type="button" class="btn btn-success" ng-click="toggleFilterRow()">Toggle Filter</button>
-      <button id="refreshButton" type="button" class="btn btn-success" ng-click="refreshData()">Refresh Data</button>  <strong>Calls Pending:</strong> <span ng-bind="callsPending"></span>
+    <div ng-controller="MainCtrl as $ctrl">
+      <button id="filterToggle" type="button" class="btn btn-success" ng-click="$ctrl.toggleFilterRow()">Toggle Filter</button>
+      <button id="refreshButton" type="button" class="btn btn-success" ng-click="$ctrl.refreshData()">Refresh Data</button>  <strong>Calls Pending:</strong> <span ng-bind="$ctrl.callsPending"></span>
       <br>
       <br>
       <strong>{{ myData.length }} rows</strong>
       <br>
-      <div id="grid1" ui-grid="gridOptions" ui-grid-cellNav ui-grid-edit ui-grid-resize-columns ui-grid-pinning ui-grid-selection ui-grid-move-columns ui-grid-importer ui-grid-exporter ui-grid-grouping class="grid"></div>
+      <div id="grid1" ui-grid="$ctrl.gridOptions" ui-grid-cellNav ui-grid-edit ui-grid-resize-columns ui-grid-pinning ui-grid-selection ui-grid-move-columns ui-grid-importer ui-grid-exporter ui-grid-grouping class="grid"></div>
     </div>
   </file>
   <file name="main.css">